From: Artem Bityutskiy <dedekind@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: [PATCH v2.1 07/17] FAT: do not manipulate s_dirt directly
Date: Fri, 5 Jun 2009 16:05:45 +0300 [thread overview]
Message-ID: <1244207155-2092-8-git-send-email-dedekind@infradead.org> (raw)
In-Reply-To: <1244207155-2092-1-git-send-email-dedekind@infradead.org>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
... use new VFS helpers instead.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
fs/fat/fatent.c | 8 ++++----
fs/fat/inode.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
index da6eea4..fa19a9d 100644
--- a/fs/fat/fatent.c
+++ b/fs/fat/fatent.c
@@ -495,7 +495,7 @@ int fat_alloc_clusters(struct inode *inode, int *cluster, int nr_cluster)
sbi->prev_free = entry;
if (sbi->free_clusters != -1)
sbi->free_clusters--;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
cluster[idx_clus] = entry;
idx_clus++;
@@ -517,7 +517,7 @@ int fat_alloc_clusters(struct inode *inode, int *cluster, int nr_cluster)
/* Couldn't allocate the free entries */
sbi->free_clusters = 0;
sbi->free_clus_valid = 1;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
err = -ENOSPC;
out:
@@ -578,7 +578,7 @@ int fat_free_clusters(struct inode *inode, int cluster)
ops->ent_put(&fatent, FAT_ENT_FREE);
if (sbi->free_clusters != -1) {
sbi->free_clusters++;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
}
if (nr_bhs + fatent.nr_bhs > MAX_BUF_PER_PAGE) {
@@ -668,7 +668,7 @@ int fat_count_free_clusters(struct super_block *sb)
}
sbi->free_clusters = free;
sbi->free_clus_valid = 1;
- sb->s_dirt = 1;
+ mark_sb_dirty(sb);
fatent_brelse(&fatent);
out:
unlock_fat(sbi);
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 2292cbf..f3b6410 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -442,7 +442,7 @@ static void fat_clear_inode(struct inode *inode)
static void fat_write_super(struct super_block *sb)
{
lock_super(sb);
- sb->s_dirt = 0;
+ mark_sb_clean(sb);
if (!(sb->s_flags & MS_RDONLY))
fat_clusters_flush(sb);
@@ -455,7 +455,7 @@ static void fat_put_super(struct super_block *sb)
lock_kernel();
- if (sb->s_dirt)
+ if (is_sb_dirty(sb))
fat_write_super(sb);
if (sbi->nls_disk) {
--
1.6.0.6
next prev parent reply other threads:[~2009-06-05 11:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 13:05 [PATCH v2.1 00/17] abstract out the super block clean/dirty state Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 01/17] VFS: introduce helpers for manipulation s_dirty flag Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 02/17] AFFS: do not manipulate s_dirt directly Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 03/17] BFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 04/17] EXOFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 05/17] EXT2: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 06/17] EXT4: " Artem Bityutskiy
2009-06-05 13:05 ` Artem Bityutskiy [this message]
2009-06-05 13:05 ` [PATCH v2.1 08/17] HFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 09/17] HFSPLUS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 10/17] JFFS2: " Artem Bityutskiy
2009-06-06 7:25 ` David Woodhouse
2009-06-07 9:21 ` Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 11/17] NILFS: " Artem Bityutskiy
2009-06-05 12:04 ` Ryusuke Konishi
2009-06-05 13:05 ` [PATCH v2.1 12/17] reiserfs: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 13/17] SYSV: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 14/17] UDF: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 15/17] UFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 16/17] XFS: " Artem Bityutskiy
2009-06-05 13:05 ` [PATCH v2.1 17/17] VFS: use is_sb_dirty helper Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244207155-2092-8-git-send-email-dedekind@infradead.org \
--to=dedekind@infradead.org \
--cc=Artem.Bityutskiy@nokia.com \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).