From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryusuke Konishi Subject: [PATCH 1/6] nilfs2: remove meaningless EBUSY case from nilfs_get_sb function Date: Mon, 8 Jun 2009 01:39:28 +0900 Message-ID: <1244392773-14230-2-git-send-email-konishi.ryusuke@lab.ntt.co.jp> References: <1244392773-14230-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp> Cc: Al Viro , Christoph Hellwig , Ryusuke Konishi , users@nilfs.org To: linux-fsdevel@vger.kernel.org Return-path: Received: from sh.osrg.net ([192.16.179.4]:35139 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbZFGQvj (ORCPT ); Sun, 7 Jun 2009 12:51:39 -0400 In-Reply-To: <1244392773-14230-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The following EBUSY case in nilfs_get_sb() is meaningless. Indeed, this error code is never returned to the caller. if (!s->s_root) { ... } else if (!(s->s_flags & MS_RDONLY)) { err = -EBUSY; } This simply removes the else case. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 6989b03..8131615 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -1172,8 +1172,6 @@ nilfs_get_sb(struct file_system_type *fs_type, int flags, s->s_flags |= MS_ACTIVE; need_to_close = 0; - } else if (!(s->s_flags & MS_RDONLY)) { - err = -EBUSY; } up(&sd.bdev->bd_mount_sem); -- 1.6.2