From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH v3 1/1] vfs: iversion truncate bug fix Date: Thu, 22 Dec 2011 08:26:30 -0500 Message-ID: <1324560391.1964.8.camel@falcor> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org To: Dmitry Kasatkin Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:55887 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909Ab1LVN3T (ORCPT ); Thu, 22 Dec 2011 08:29:19 -0500 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Dec 2011 06:29:18 -0700 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 2011-12-22 at 12:54 +0200, Dmitry Kasatkin wrote: > When a file is truncated with truncate()/ftruncate() and then closed, > iversion is not updated. This patch uses ATTR_SIZE flag as an indication > to increment iversion. > > Signed-off-by: Dmitry Kasatkin Acked-by: Mimi Zohar (Stable should be cc'ed on this patch.) thanks, Mimi > --- > fs/attr.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/fs/attr.c b/fs/attr.c > index 7ee7ba4..b8f55c4 100644 > --- a/fs/attr.c > +++ b/fs/attr.c > @@ -176,6 +176,11 @@ int notify_change(struct dentry * dentry, struct iattr * attr) > return -EPERM; > } > > + if ((ia_valid & ATTR_SIZE) && IS_I_VERSION(inode)) { > + if (attr->ia_size != inode->i_size) > + inode_inc_iversion(inode); > + } > + > if ((ia_valid & ATTR_MODE)) { > mode_t amode = attr->ia_mode; > /* Flag setting protected by i_mutex */