Linux-Fsdevel Archive on
 help / color / Atom feed
From: Eric Dumazet <>
To: Eric Wong <>, David Miller <>
Cc:,,, Willy Tarreau <>
Subject: Re: splice() giving unexpected EOF in 3.7.3 and 3.8-rc4+
Date: Fri, 18 Jan 2013 22:13:16 -0800
Message-ID: <1358575996.3464.447.camel@edumazet-glaptop> (raw)
In-Reply-To: <1358574847.3464.422.camel@edumazet-glaptop>

On Fri, 2013-01-18 at 21:54 -0800, Eric Dumazet wrote:

> Hmm, this might be already fixed in net-next tree, could you try it ?

Yes, running your program on net-next seems OK.

David, we need the two following commits.

They actually fixed a bug : current code in Linus tree
can push to the pipe a 0-length frag, because of the :

flen = min_t(unsigned int, flen, PAGE_SIZE - poff);

It can happen if poff == PAGE_SIZE, when one skb frag has this
particular starting offset.

commit 9ca1b22d6d228177e6f929f6818a1cd3d5e30c4a
Author: Eric Dumazet <>
Date:   Sat Jan 5 21:31:18 2013 +0000

    net: splice: avoid high order page splitting
    splice() can handle pages of any order, but network code tries hard to
    split them in PAGE_SIZE units. Not quite successfully anyway, as
    __splice_segment() assumed poff < PAGE_SIZE. This is true for
    the skb->data part, not necessarily for the fragments.
    This patch removes this logic to give the pages as they are in the skb.
    Signed-off-by: Eric Dumazet <>
    Cc: Willy Tarreau <>
    Signed-off-by: David S. Miller <>

commit 18aafc622abf492809723d9c5a3c5dcea287169e
Author: Eric Dumazet <>
Date:   Fri Jan 11 14:46:37 2013 +0000

    net: splice: fix __splice_segment()
    commit 9ca1b22d6d2 (net: splice: avoid high order page splitting)
    forgot that skb->head could need a copy into several page frags.
    This could be the case for loopback traffic mostly.
    Also remove now useless skb argument from linear_to_page()
    and __splice_segment() prototypes.
    Signed-off-by: Eric Dumazet <>
    Cc: Willy Tarreau <>
    Signed-off-by: David S. Miller <>

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  4:49 Eric Wong
2013-01-19  5:54 ` Eric Dumazet
2013-01-19  6:13   ` Eric Dumazet [this message]
2013-01-19  7:04     ` Willy Tarreau
2013-01-19  7:15     ` Eric Wong
2013-01-21  4:21     ` David Miller
2013-02-08  2:39       ` Eric Wong
2013-02-08  3:26         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358575996.3464.447.camel@edumazet-glaptop \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on

Archives are clonable:
	git clone --mirror linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ \
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone