From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: [PATCH V8 18/33] fs: create file_readable() and file_writable() functions Date: Thu, 25 Jul 2013 12:50:44 -0500 Message-ID: <1374774659-13121-19-git-send-email-dave.kleikamp@oracle.com> References: <1374774659-13121-1-git-send-email-dave.kleikamp@oracle.com> Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , "Maxim V. Patlasov" , Zach Brown , Dave Kleikamp To: linux-kernel@vger.kernel.org Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:19803 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756822Ab3GYRvy (ORCPT ); Thu, 25 Jul 2013 13:51:54 -0400 In-Reply-To: <1374774659-13121-1-git-send-email-dave.kleikamp@oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Create functions to simplify if file_ops contain either a read or aio_read op, or likewise write or aio_write. We will be adding read_iter and write_iter and don't need to be complicating the code in multiple places. Signed-off-by: Dave Kleikamp --- drivers/mtd/nand/nandsim.c | 4 ++-- drivers/usb/gadget/storage_common.c | 4 ++-- fs/read_write.c | 14 +++++++------- include/linux/fs.h | 10 ++++++++++ 4 files changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c index cb38f3d..6a44ba6 100644 --- a/drivers/mtd/nand/nandsim.c +++ b/drivers/mtd/nand/nandsim.c @@ -576,12 +576,12 @@ static int alloc_device(struct nandsim *ns) cfile = filp_open(cache_file, O_CREAT | O_RDWR | O_LARGEFILE, 0600); if (IS_ERR(cfile)) return PTR_ERR(cfile); - if (!cfile->f_op || (!cfile->f_op->read && !cfile->f_op->aio_read)) { + if (!file_readable(cfile)) { NS_ERR("alloc_device: cache file not readable\n"); err = -EINVAL; goto err_close; } - if (!cfile->f_op->write && !cfile->f_op->aio_write) { + if (!file_writable(cfile)) { NS_ERR("alloc_device: cache file not writeable\n"); err = -EINVAL; goto err_close; diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c index dbce3a9..a801a00 100644 --- a/drivers/usb/gadget/storage_common.c +++ b/drivers/usb/gadget/storage_common.c @@ -450,11 +450,11 @@ static int fsg_lun_open(struct fsg_lun *curlun, const char *filename) * If we can't read the file, it's no good. * If we can't write the file, use it read-only. */ - if (!(filp->f_op->read || filp->f_op->aio_read)) { + if (!file_readable(filp)) { LINFO(curlun, "file not readable: %s\n", filename); goto out; } - if (!(filp->f_op->write || filp->f_op->aio_write)) + if (!file_writable(filp)) ro = 1; size = i_size_read(inode->i_mapping->host); diff --git a/fs/read_write.c b/fs/read_write.c index 122a384..022929c 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -385,7 +385,7 @@ ssize_t vfs_read(struct file *file, char __user *buf, size_t count, loff_t *pos) if (!(file->f_mode & FMODE_READ)) return -EBADF; - if (!file->f_op || (!file->f_op->read && !file->f_op->aio_read)) + if (!file_readable(file)) return -EINVAL; if (unlikely(!access_ok(VERIFY_WRITE, buf, count))) return -EFAULT; @@ -435,7 +435,7 @@ ssize_t __kernel_write(struct file *file, const char *buf, size_t count, loff_t const char __user *p; ssize_t ret; - if (!file->f_op || (!file->f_op->write && !file->f_op->aio_write)) + if (!file_writable(file)) return -EINVAL; old_fs = get_fs(); @@ -462,7 +462,7 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_ if (!(file->f_mode & FMODE_WRITE)) return -EBADF; - if (!file->f_op || (!file->f_op->write && !file->f_op->aio_write)) + if (!file_writable(file)) return -EINVAL; if (unlikely(!access_ok(VERIFY_READ, buf, count))) return -EFAULT; @@ -781,7 +781,7 @@ ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, { if (!(file->f_mode & FMODE_READ)) return -EBADF; - if (!file->f_op || (!file->f_op->aio_read && !file->f_op->read)) + if (!file_readable(file)) return -EINVAL; return do_readv_writev(READ, file, vec, vlen, pos); @@ -794,7 +794,7 @@ ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, { if (!(file->f_mode & FMODE_WRITE)) return -EBADF; - if (!file->f_op || (!file->f_op->aio_write && !file->f_op->write)) + if (!file_writable(file)) return -EINVAL; return do_readv_writev(WRITE, file, vec, vlen, pos); @@ -968,7 +968,7 @@ static size_t compat_readv(struct file *file, goto out; ret = -EINVAL; - if (!file->f_op || (!file->f_op->aio_read && !file->f_op->read)) + if (!file_readable(file)) goto out; ret = compat_do_readv_writev(READ, file, vec, vlen, pos); @@ -1035,7 +1035,7 @@ static size_t compat_writev(struct file *file, goto out; ret = -EINVAL; - if (!file->f_op || (!file->f_op->aio_write && !file->f_op->write)) + if (!file_writable(file)) goto out; ret = compat_do_readv_writev(WRITE, file, vec, vlen, pos); diff --git a/include/linux/fs.h b/include/linux/fs.h index d716a29..fc1e2a8 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1652,6 +1652,16 @@ struct file_operations { int (*show_fdinfo)(struct seq_file *m, struct file *f); }; +static inline int file_readable(struct file *filp) +{ + return filp && (filp->f_op->read || filp->f_op->aio_read); +} + +static inline int file_writable(struct file *filp) +{ + return filp && (filp->f_op->write || filp->f_op->aio_write); +} + struct inode_operations { struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int); void * (*follow_link) (struct dentry *, struct nameidata *); -- 1.8.3.4