From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chandra Seetharaman Subject: Re: [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV Date: Tue, 13 Aug 2013 15:50:48 -0500 Message-ID: <1376427048.971.17.camel@chandra-dt.ibm.com> References: <1375828029-26360-1-git-send-email-sekharan@us.ibm.com> <1375828029-26360-2-git-send-email-sekharan@us.ibm.com> <520A9A2F.5090009@sgi.com> Reply-To: sekharan@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel , Abhijith Das , Jan Kara , Steven Whitehouse , xfs@oss.sgi.com To: Rich Johnston Return-path: Received: from e9.ny.us.ibm.com ([32.97.182.139]:42846 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759012Ab3HMUvD (ORCPT ); Tue, 13 Aug 2013 16:51:03 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Aug 2013 16:51:02 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 1A3E66E8041 for ; Tue, 13 Aug 2013 16:50:54 -0400 (EDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7DKox8U34996284 for ; Tue, 13 Aug 2013 16:50:59 -0400 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7DKouok023098 for ; Tue, 13 Aug 2013 14:50:58 -0600 In-Reply-To: <520A9A2F.5090009@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 2013-08-13 at 15:42 -0500, Rich Johnston wrote: > Hey Chandra, > > Nice addition to quotas. Just a couple of comments. > > On 08/06/2013 05:27 PM, Chandra Seetharaman wrote: > > . . . > > > > +/* > > + * fs_quota_statv is the used by Q_XGETQSTATV for a given file system. It > Remove extra word ^^^^ > > > + * provides a centralized way to get meta information about the quota > > + * subsystem. eg. space taken up for user, group, and project quotas, number > > + * of dquots currently incore. > > + * > > + * This version has proper versioning support with appropriate padding for > > + * future expansions, and ability to expand for future without creating any > > + * backwward compatibility issues. > backward is misspelled (extra w) > > > + * > > + * For Q_XGETQSTATV, user space caller need to specify fs_quota_statv.qs_version > > + * to the version of data they are interested in. Kernel will fill the data > > + * fields relevant to that version. > > + * > > + * If kernel does not support user space caller specified version, EINVAL will > > + * be returned. User space caller can then reduce the version number and retry > > + * the same command. > > + */ > This was a little difficult to follow, suggest rewording a little, > something like: > > Q_XGETQSTATV uses the passed in value of the requested version via > fs_quota_statv.qs_version to determine the return data layout of > fs_quota_statv. > > Will make all the suggested fixes. > It would be nice to get this information documented in the quotactl(2) > manpage similar to Q_XGETQSTAT. Once it is in the kernel will work with Jan Kara to add the relevant changes to user space. Thanks Chandra > > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs >