From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968B7C28CC2 for ; Wed, 29 May 2019 10:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 708DF208CB for ; Wed, 29 May 2019 10:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbfE2KzQ convert rfc822-to-8bit (ORCPT ); Wed, 29 May 2019 06:55:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725894AbfE2KzQ (ORCPT ); Wed, 29 May 2019 06:55:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92A5430B2443; Wed, 29 May 2019 10:55:15 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-173.rdu2.redhat.com [10.10.120.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B4BC2F2A0; Wed, 29 May 2019 10:55:11 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <155905930702.7587.7100265859075976147.stgit@warthog.procyon.org.uk> <155905933492.7587.6968545866041839538.stgit@warthog.procyon.org.uk> To: Jann Horn Cc: dhowells@redhat.com, Al Viro , raven@themaw.net, linux-fsdevel , Linux API , linux-block@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module , kernel list Subject: Re: [PATCH 3/7] vfs: Add a mount-notification facility MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13969.1559127310.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 29 May 2019 11:55:10 +0100 Message-ID: <13970.1559127310@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 29 May 2019 10:55:15 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Jann Horn wrote: > > + /* Global root? */ > > + if (mnt != parent) { > > + cursor.dentry = READ_ONCE(mnt->mnt_mountpoint); > > + mnt = parent; > > + cursor.mnt = &mnt->mnt; > > + continue; > > + } > > + break; > > (nit: this would look clearer if you inverted the condition and wrote > it as "if (mnt == parent) break;", then you also wouldn't need that > "continue" or the braces) It does look better with the logic inverted, but you *do* still need the continue. After the if-statement, there is: cursor.dentry = cursor.dentry->d_parent; which we need to skip. It might make sense to move that into an else-statement from an aesthetic point of view. David