linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, adrian.hunter@intel.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RESEND] ubifs: Introduce a mount option of force_atime.
Date: Tue, 23 Jun 2015 13:44:00 +0300	[thread overview]
Message-ID: <1435056240.7659.69.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <55892D18.3020203@cn.fujitsu.com>

On Tue, 2015-06-23 at 17:55 +0800, Dongsheng Yang wrote:
> In short, I think force_atime to ubifs is the choice from my opinion.

So will we end up with this:

-o - no atime support
-o atime - no atime support
-o noatime - same, no atime support
-o force_atime - full atime support
-o relatime - relative atime support
-o lazyatime - lazy atime support

IOW, atime/noatime mount options have no effect on UBIFS. To have full
atime support - people have to use "force_atime". And then the rest of
the standard options are supported.

So if you are the user, would not you find this confusing and
inconsistent? I would.


How about this alternative: we preserve current behavior, but we
introduce a compile-time configuration option which enables atime
support _and_ changes the default behavior to match the behavior of the
mainstream file-systems.

Or to put it differently.

1. We introduce the UBIFS_ATIME_SUPPORT configuration option. This
option will be off by default.

3. If UBIFS_ATIME_SUPPORT is off, users get the current (legacy)
behavior. Atime is not supported. The atime/noatime/relatime/lazyatime
mount options are ignored.

4. If UBIFS_ATIME_SUPPORT is on, UBIFS supports atime by default. I.e.:

-o - full atime support
-o atime - full atime support
-o noatime - no atime support

We may also print a fat big warning from the mount function about the
fact that atime support is enabled. Just in case a legacy user enabled
this option.

How does this sound to you?

Artem.


  reply	other threads:[~2015-06-23 10:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 10:07 [PATCH RESEND] ubifs: Introduce a mount option of force_atime Dongsheng Yang
2015-06-08 22:35 ` Richard Weinberger
2015-06-08 22:55 ` Richard Weinberger
2015-06-09  2:57   ` Dongsheng Yang
2015-06-09  3:24   ` Dongsheng Yang
2015-06-09  5:00     ` Dongsheng Yang
2015-06-09  5:09       ` Dongsheng Yang
2015-06-09  6:36 ` Artem Bityutskiy
2015-06-09  8:02   ` Richard Weinberger
2015-06-10  3:16     ` Dongsheng Yang
2015-06-10  9:21       ` Artem Bityutskiy
2015-06-10 10:10         ` Dongsheng Yang
2015-06-10 10:25           ` Artem Bityutskiy
2015-06-10 10:34             ` Dongsheng Yang
2015-06-10 11:05               ` Artem Bityutskiy
2015-06-23  9:55                 ` Dongsheng Yang
2015-06-23 10:44                   ` Artem Bityutskiy [this message]
2015-06-23 23:49                     ` Dongsheng Yang
2015-06-24  0:33                     ` Dave Chinner
2015-06-24 16:04                       ` Artem Bityutskiy
2015-06-25  9:55                       ` Dongsheng Yang
2015-06-25 10:08                         ` Artem Bityutskiy
2015-06-25 10:10                           ` Dongsheng Yang
2015-06-25 11:28                             ` Artem Bityutskiy
2015-06-26  1:17                               ` Dongsheng Yang
2015-06-26  7:01                                 ` Artem Bityutskiy
2015-06-26  7:13                                   ` Dongsheng Yang
2015-06-26  7:43                                     ` Artem Bityutskiy
2015-06-26  7:52                                       ` Dongsheng Yang
2015-06-26  8:19                                         ` Artem Bityutskiy
2015-06-26  8:22                                           ` Dongsheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435056240.7659.69.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=yangds.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).