From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [RFC PATCH 6/6] powerpc/kvm: change the condition of identifying hugetlb vm Date: Tue, 7 Jul 2015 14:47:41 -0500 Message-ID: <1436298461.2658.39.camel@freescale.com> References: <1433917639-31699-1-git-send-email-wenweitaowenwei@gmail.com> <1433917639-31699-7-git-send-email-wenweitaowenwei@gmail.com> <1435873760.10531.11.camel@freescale.com> <1436218475.2658.14.camel@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Izik Eidus , , , Hugh Dickins , , , , , , , , , , , To: wenwei tao Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2015-07-07 at 16:05 +0800, wenwei tao wrote: > Hi Scott > > I understand what you said. > > I will use the function 'is_vm_hugetlb_page()' to hide the bit > combinations according to your comments in the next version of patch > set. > > But for the situation like below, there isn't an obvious structure > 'vma', using 'is_vm_hugetlb_page()' maybe costly or even not possible. > void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, > unsigned long end, unsigned long vmflag) > { > ... > > if (end == TLB_FLUSH_ALL || tlb_flushall_shift == -1 > || vmflag & VM_HUGETLB) { > local_flush_tlb(); > goto flush_all; > } > ... > } Add a function that operates on the flags directly, then. -Scott -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org