From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1468989000.1900.94.camel@perches.com> Subject: Re: [PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form From: Joe Perches To: Nicolas Pitre , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Date: Tue, 19 Jul 2016 21:30:00 -0700 In-Reply-To: <1468988424-32671-3-git-send-email-nicolas.pitre@linaro.org> References: <1468988424-32671-1-git-send-email-nicolas.pitre@linaro.org> <1468988424-32671-3-git-send-email-nicolas.pitre@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, 2016-07-20 at 00:20 -0400, Nicolas Pitre wrote: > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c [] > @@ -15,6 +15,8 @@ > � * JAN/99 -- coded full program relocation (gerg@snapgear.com) > � */ > � > +#define pr_fmt(fmt) "BINFMT_FLAT: : " fmt Why the double colon? Much more common would be #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > @@ -106,8 +98,8 @@ static struct linux_binfmt flat_format = { > � > �static int flat_core_dump(struct coredump_params *cprm) > �{ > - printk("Process %s:%d received signr %d and should have core dumped\n", > - current->comm, current->pid, cprm->siginfo->si_signo); > + pr_warning("Process %s:%d received signr %d and should have core dumped\n", > + ���current->comm, current->pid, cprm->siginfo->si_signo); Prefer pr_warn > � return(1); > �} > � > @@ -190,17 +182,17 @@ static int decompress_exec( > � loff_t fpos; > � int ret, retval; > � > - DBG_FLT("decompress_exec(offset=%lx,buf=%p,len=%lx)\n",offset, dst, len); > + pr_debug("decompress_exec(offset=%lx,buf=%p,len=%lx)\n",offset, dst, len); Generally unnecessary as the function tracer works well > � > � memset(&strm, 0, sizeof(strm)); > � strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL); > � if (strm.workspace == NULL) { > - DBG_FLT("binfmt_flat: no memory for decompress workspace\n"); > + pr_debug("no memory for decompress workspace\n"); > � return -ENOMEM; > � } > � buf = kmalloc(LBUFSIZE, GFP_KERNEL); > � if (buf == NULL) { > - DBG_FLT("binfmt_flat: no memory for read buffer\n"); > + pr_debug("no memory for read buffer\n"); Unnecessary OOM messages as allocs do a stack dump