From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1494502687.6967.2.camel@linux.intel.com> Subject: Re: [PATCH 03/16] uuid: rename uuid types From: Andy Shevchenko To: David Howells , Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Date: Thu, 11 May 2017 14:38:07 +0300 In-Reply-To: <2612.1494440436@warthog.procyon.org.uk> References: <20170510180214.16852-4-hch@lst.de> <20170510180214.16852-1-hch@lst.de> <2612.1494440436@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, 2017-05-10 at 19:20 +0100, David Howells wrote: > Christoph Hellwig wrote: > > > -#define NULL_UUID_LE > > \ > > - UUID_LE(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#define NULL_GUID > > \ > > + GUID(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > +      0x00, 0x00, 0x00, 0x00) > >   > > -#define NULL_UUID_BE > > \ > > - UUID_BE(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#define NULL_UUID > > \ > > + UUID(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > +      0x00, 0x00, 0x00, 0x00) > > These are UAPI and ought not to be renamed. > Good point. I see in the branch it's already fixed. -- Andy Shevchenko Intel Finland Oy