From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f42.google.com ([209.85.160.42]:40439 "EHLO mail-pl0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbdKWEVh (ORCPT ); Wed, 22 Nov 2017 23:21:37 -0500 Received: by mail-pl0-f42.google.com with SMTP id 62so2000597plc.7 for ; Wed, 22 Nov 2017 20:21:37 -0800 (PST) Message-ID: <1511410895.2541.16.camel@dubeyko.com> Subject: Re: [PATCH] hfsplus: fix the bug that cannot recognize files with hangul file name From: Viacheslav Dubeyko To: tchou , "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?= Cc: linux-fsdevel@vger.kernel.org, linux-fsdevel-owner@vger.kernel.org, htl10@users.sourceforge.net Date: Wed, 22 Nov 2017 20:21:35 -0800 In-Reply-To: <080024a85dc413b72c181c6e75bdc736@synology.com> References: <1510906805-2142-1-git-send-email-tchou@synology.com> <20171119005704.GA3495@debian.home> <080024a85dc413b72c181c6e75bdc736@synology.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 2017-11-23 at 11:57 +0800, tchou wrote: > > > > Could you please share the examples of incorrect and correct > > behaviour? > > > > What is it exactly that you are trying to fix? You mention an > > issue  > > with > > hangul characters, but I failed to trigger it. Could you expand on  > > that? > > > Hi all, > There is an example.I use Mac mini to format my usb disk to HFS+ and  > touch > the file with filename "공유"(a Korean actor, https://goo.gl/VcBsrn) > on  > it. > After it, I mount the usb disk on my ubuntu(Linux 4.14.0+) and get > the > following error message when trying to ls and cp the file: > Could you share the all mount options that you used? It looks that you simply don't use the proper mount options set under the Linux. Because MacOS X will mount properly always. Thanks, Vyacheslav Dubeyko. > ls: cannot access 공유: No such file or directory > cp: cannot stat ‘공유’: No such file or directory > > It seem's a problem for a long time(https://goo.gl/LiWGe5). > After applying my patch, I can ls and cp the file correctly. > > > > > On Fri, Nov 17, 2017 at 04:20:05PM +0800, Ting-Chang Hou wrote: > > > > > > The unicode of hangul from macOS is decomposed. There has a bug > > > that > > > mistake decomposed unicode for composed when change unicode to > > > ascii, > > > so it cannot recognize the hangul correctly. > > > > > > Signed-off-by: Ting-Chang Hou > > > --- > > >  fs/hfsplus/unicode.c | 2 +- > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/fs/hfsplus/unicode.c b/fs/hfsplus/unicode.c > > > index dfa90c2..2daf7b0 100644 > > > --- a/fs/hfsplus/unicode.c > > > +++ b/fs/hfsplus/unicode.c > > > @@ -135,7 +135,7 @@ int hfsplus_uni2asc(struct super_block *sb, > > >   ustrlen = be16_to_cpu(ustr->length); > > >   len = *len_p; > > >   ce1 = NULL; > > > - compose = !test_bit(HFSPLUS_SB_NODECOMPOSE, > > > &HFSPLUS_SB(sb)->flags); > > > + compose = test_bit(HFSPLUS_SB_NODECOMPOSE, > > > &HFSPLUS_SB(sb)->flags); > > I'm not sure this is a mistake. The developers probably wanted the > > filenames to be recomposed before being presented in utf8. With > > your  > > patch, > > if you try the following (with the default mount options): > > > >   touch Á > >   ls | hexdump -C > > > > the utf8 output filename will be using the combining accent (CC > > 81)  > > instead > > of the Á character (C3 81). This is a bit annoying because it > > won't  > > print > > correctly in my terminal anymore. > I'm not exatly know why combining accent cannot print correctly in  > terminal > and how to avoid it. Whether apply my patch or not, my terminal > cannot > print the hangul charactor correctly. > >