From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay0052.hostedemail.com ([216.40.44.52]:44410 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751136AbdKXGvi (ORCPT ); Fri, 24 Nov 2017 01:51:38 -0500 Message-ID: <1511506294.8230.6.camel@perches.com> Subject: Re: [PATCH] fat: Fix sb_rdonly() change From: Joe Perches To: OGAWA Hirofumi Cc: Andrew Morton , David Howells , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Date: Thu, 23 Nov 2017 22:51:34 -0800 In-Reply-To: <873754i512.fsf@mail.parknet.co.jp> References: <87mv3d5x51.fsf@mail.parknet.co.jp> <87ine15wzx.fsf@mail.parknet.co.jp> <1511470178.5308.2.camel@perches.com> <873754i512.fsf@mail.parknet.co.jp> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2017-11-24 at 15:07 +0900, OGAWA Hirofumi wrote: > Joe Perches writes: > > > On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote: > > > Ouch forgot to add stable@ > > > > > > -- > > > commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug. > > > > I think your commit message needs a bit more information. > > > > It'd be useful to describe that the introduction of > > sb_rdonly converted the bitwise & to a boolean and so > > this conversion and comparison was made defective. > > > > Are there any other instances of defective comparisons? > > Please ask to that patch author. The patch author, David Howells, is on the cc list. btw: It seems all the the other uses use a (bool) cast of the (*flags & MS_RDONLY) and a comparison of sb_rdonly(sb). It would make sense to change the argument type of the ext[24]_setup_super int read_only arg to bool to match the sb_rdonly() type.