linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 00/10] Eliminate delegation self-conflicts v2
Date: Mon, 19 Mar 2018 10:36:24 -0400	[thread overview]
Message-ID: <1521470194-24840-1-git-send-email-bfields@redhat.com> (raw)

From: "J. Bruce Fields" <bfields@redhat.com>

This is my second attempt to fix the NFS server so we don't
unnecessarily recall delegations when the operation breaking the
delegation comes from the same client that holds the delegation.

To do that we need some way to pass the identity of the breaker down
through the VFS.  In my first attempt I tried passing that explicitly,
but that touches a lot of code.  So instead I'm experimenting with
adding a field to the cred struct.

Testing has confirmed that this works.  (And that the pynfs tests are
broken--they *require* the server to break delegations on operations
coming from the client, even though that's the less desireable behavior.
I'm fixing that...).

J. Bruce Fields (10):
  vfs: remove unnecessary fl_owner_t typedef
  nfsd: simplify put of fi_deleg_file
  nfsd: simplify nfs4_put_deleg_lease calls
  nfsd4: set fl_owner to delegation, not file pointer
  nfsd4: dp->dl_stid.sc_file doesn't need locking
  nfsd: make nfs4_get_existing_delegation less confusing
  nfsd: factor out common delegation-destruction code
  nfsd: move sc_file assignment into alloc_init_deleg
  nfsd: create a separate lease for each delegation
  nfsd: clients don't need to break their own delegations

 Documentation/filesystems/Locking          |   2 +
 Documentation/filesystems/vfs.txt          |   2 +-
 arch/ia64/kernel/perfmon.c                 |   2 +-
 arch/powerpc/platforms/cell/spufs/file.c   |   2 +-
 arch/tile/kernel/hardwall.c                |   2 +-
 drivers/android/binder.c                   |   2 +-
 drivers/char/ps3flash.c                    |   2 +-
 drivers/char/xillybus/xillybus_core.c      |   2 +-
 drivers/firmware/efi/capsule-loader.c      |   2 +-
 drivers/input/evdev.c                      |   2 +-
 drivers/misc/mic/scif/scif_fd.c            |   2 +-
 drivers/scsi/osst.c                        |   2 +-
 drivers/scsi/st.c                          |   2 +-
 drivers/staging/lustre/lustre/llite/file.c |   2 +-
 drivers/usb/class/cdc-wdm.c                |   2 +-
 drivers/usb/usb-skeleton.c                 |   2 +-
 fs/afs/internal.h                          |   2 +-
 fs/afs/write.c                             |   2 +-
 fs/cifs/cifsfs.h                           |   2 +-
 fs/cifs/file.c                             |   4 +-
 fs/ecryptfs/file.c                         |   2 +-
 fs/exofs/file.c                            |   2 +-
 fs/f2fs/file.c                             |   2 +-
 fs/fuse/file.c                             |  13 +-
 fs/fuse/fuse_i.h                           |   2 +-
 fs/lockd/clntproc.c                        |   4 +-
 fs/lockd/svc4proc.c                        |   2 +-
 fs/lockd/svcproc.c                         |   2 +-
 fs/locks.c                                 |   6 +-
 fs/nfs/file.c                              |   2 +-
 fs/nfs/inode.c                             |   2 +-
 fs/nfs/nfs4_fs.h                           |   2 +-
 fs/nfs/nfs4file.c                          |   2 +-
 fs/nfs/nfs4state.c                         |   8 +-
 fs/nfsd/auth.c                             |   2 +
 fs/nfsd/nfs4proc.c                         |   1 +
 fs/nfsd/nfs4state.c                        | 267 ++++++++++++-----------------
 fs/nfsd/nfssvc.c                           |   1 +
 fs/notify/dnotify/dnotify.c                |   6 +-
 fs/open.c                                  |   2 +-
 include/linux/cred.h                       |   3 +
 include/linux/dnotify.h                    |   6 +-
 include/linux/fs.h                         |  18 +-
 include/linux/lockd/lockd.h                |   4 +-
 include/linux/nfs_fs.h                     |   4 +-
 include/linux/sunrpc/svc.h                 |   1 +
 include/trace/events/filelock.h            |   6 +-
 ipc/mqueue.c                               |   2 +-
 48 files changed, 193 insertions(+), 223 deletions(-)

-- 
2.14.3

             reply	other threads:[~2018-03-19 14:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 14:36 J. Bruce Fields [this message]
2018-03-19 14:36 ` [PATCH 01/10] vfs: remove unnecessary fl_owner_t typedef J. Bruce Fields
2018-03-19 14:36 ` [PATCH 02/10] nfsd: simplify put of fi_deleg_file J. Bruce Fields
2018-03-19 14:36 ` [PATCH 03/10] nfsd: simplify nfs4_put_deleg_lease calls J. Bruce Fields
2018-03-19 14:36 ` [PATCH 04/10] nfsd4: set fl_owner to delegation, not file pointer J. Bruce Fields
2018-03-19 14:36 ` [PATCH 05/10] nfsd4: dp->dl_stid.sc_file doesn't need locking J. Bruce Fields
2018-03-19 14:36 ` [PATCH 06/10] nfsd: make nfs4_get_existing_delegation less confusing J. Bruce Fields
2018-03-19 14:36 ` [PATCH 07/10] nfsd: factor out common delegation-destruction code J. Bruce Fields
2018-03-19 14:36 ` [PATCH 08/10] nfsd: move sc_file assignment into alloc_init_deleg J. Bruce Fields
2018-03-19 14:36 ` [PATCH 09/10] nfsd: create a separate lease for each delegation J. Bruce Fields
2018-03-19 14:36 ` [PATCH 10/10] nfsd: clients don't need to break their own delegations J. Bruce Fields
2018-03-20 13:10 ` [PATCH 00/10] Eliminate delegation self-conflicts v2 Jeff Layton
2018-03-20 13:35 ` [PATCH 10/10] nfsd: clients don't need to break their own delegations David Howells
2018-03-20 13:46   ` Trond Myklebust
2018-03-20 14:49     ` J. Bruce Fields
2018-03-20 15:13       ` Trond Myklebust
2018-03-20 16:02         ` bfields
2018-09-06 19:40           ` bfields
2018-03-20 14:52   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521470194-24840-1-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).