From: Chengguang Xu <cgxu519@gmx.com>
To: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Cc: Chengguang Xu <cgxu519@gmx.com>
Subject: [PATCH] vfs: delete unnecessary assignment in vfs_listxattr
Date: Wed, 16 May 2018 13:34:52 +0800 [thread overview]
Message-ID: <1526448892-15129-1-git-send-email-cgxu519@gmx.com> (raw)
It seems the first error assignment in if branch is redundant.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/xattr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xattr.c b/fs/xattr.c
index 61cd28b..8686050 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -354,7 +354,6 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name,
if (error)
return error;
if (inode->i_op->listxattr && (inode->i_opflags & IOP_XATTR)) {
- error = -EOPNOTSUPP;
error = inode->i_op->listxattr(dentry, list, size);
} else {
error = security_inode_listsecurity(inode, list, size);
--
1.8.3.1
reply other threads:[~2018-05-16 5:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526448892-15129-1-git-send-email-cgxu519@gmx.com \
--to=cgxu519@gmx.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).