linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vfs: delete unnecessary assignment in vfs_listxattr
@ 2018-05-16  5:34 Chengguang Xu
  0 siblings, 0 replies; only message in thread
From: Chengguang Xu @ 2018-05-16  5:34 UTC (permalink / raw)
  To: viro, linux-fsdevel; +Cc: Chengguang Xu

It seems the first error assignment in if branch is redundant.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
 fs/xattr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xattr.c b/fs/xattr.c
index 61cd28b..8686050 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -354,7 +354,6 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name,
 	if (error)
 		return error;
 	if (inode->i_op->listxattr && (inode->i_opflags & IOP_XATTR)) {
-		error = -EOPNOTSUPP;
 		error = inode->i_op->listxattr(dentry, list, size);
 	} else {
 		error = security_inode_listsecurity(inode, list, size);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-05-16  5:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16  5:34 [PATCH] vfs: delete unnecessary assignment in vfs_listxattr Chengguang Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).