From: David Howells <dhowells@redhat.com>
To: viro@zeniv.linux.org.uk
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] afs: Move the source fs parameter to the first position
Date: Tue, 21 Aug 2018 10:55:18 +0100 [thread overview]
Message-ID: <153484531821.1183.17951530333694057258.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <153484529922.1183.17405985592221413059.stgit@warthog.procyon.org.uk>
Move the source fs parameter to the first position in the parameter list,
numerically speaking. Note that it isn't moved in the key string table as
that's a sorted list.
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/afs/super.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/afs/super.c b/fs/afs/super.c
index 7c97836e7937..15c5eb9412bb 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -68,16 +68,16 @@ static struct kmem_cache *afs_inode_cachep;
static atomic_t afs_count_active_inodes;
enum afs_param {
+ Opt_source,
Opt_autocell,
Opt_dyn,
- Opt_source,
nr__afs_params
};
static const struct fs_parameter_spec afs_param_specs[nr__afs_params] = {
+ [Opt_source] = { fs_param_is_string },
[Opt_autocell] = { fs_param_takes_no_value },
[Opt_dyn] = { fs_param_takes_no_value },
- [Opt_source] = { fs_param_is_string },
};
static const struct constant_table afs_param_keys[] = {
@@ -900,14 +900,6 @@ static int afs_get_fsinfo(struct dentry *dentry, struct fsinfo_kparams *params)
if (params->Mth)
return -ENODATA;
switch (params->Nth) {
- case Opt_autocell:
- if (as->autocell)
- str = "autocell";
- goto string;
- case Opt_dyn:
- if (dyn_root)
- str = "dyn";
- goto string;
case Opt_source:
if (dyn_root)
return 0;
@@ -918,6 +910,14 @@ static int afs_get_fsinfo(struct dentry *dentry, struct fsinfo_kparams *params)
volume->type == AFSVL_RWVOL ? "" :
volume->type == AFSVL_ROVOL ? ".readonly" :
".backup");
+ case Opt_autocell:
+ if (as->autocell)
+ str = "autocell";
+ goto string;
+ case Opt_dyn:
+ if (dyn_root)
+ str = "dyn";
+ goto string;
default:
return -ENODATA;
}
next prev parent reply other threads:[~2018-08-21 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 9:54 vfs: Fixes/adjustments for mount API stuff David Howells
2018-08-21 9:55 ` [PATCH 1/6] vfs: Fix vfs_dup_fs_context() David Howells
2018-08-21 9:55 ` [PATCH 2/6] vfs: Fix fs_context logging when there's no log David Howells
2018-08-21 9:55 ` David Howells [this message]
2018-08-21 9:55 ` [PATCH 4/6] vfs: Pass path info fsinfo and rename get_fsinfo sb op to fsinfo David Howells
2018-08-21 9:55 ` [PATCH 5/6] vfs: Adjust fsinfo sample output David Howells
2018-08-21 9:55 ` [PATCH 6/6] proc: Set correct userns for new proc super created by a new pid_namespace David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153484531821.1183.17951530333694057258.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).