From: Viacheslav Dubeyko <slava@dubeyko.com>
To: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org,
Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Subject: Re: [PATCH 1/2] hfsplus: prevent crash on exit from failed search
Date: Wed, 22 Aug 2018 13:27:47 -0700 [thread overview]
Message-ID: <1534969667.2878.8.camel@slavad-ubuntu-14.04> (raw)
In-Reply-To: <20180822181105.ettqvxbgedsdc6kw@eaf>
On Wed, 2018-08-22 at 15:11 -0300, Ernesto A. Fernández wrote:
> On Tue, Aug 21, 2018 at 04:02:24PM -0700, Andrew Morton wrote:
> > On Mon, 02 Jul 2018 11:01:37 -0700 Viacheslav Dubeyko <slava@dubeyko.com> wrote:
> >
> > > On Fri, 2018-06-29 at 15:34 -0300, Ernesto A. Fernández wrote:
> > > > The hfs_find_exit() function expects fd->bnode to be NULL after a
> > > > search has failed. The hfs_brec_insert() function may instead set
> > > > it to an error-valued pointer. Fix this to prevent a crash.
> > > >
> > > > Reported-by: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
> > > > Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
> > > > ---
> > > > fs/hfsplus/brec.c | 7 ++++---
> > > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/fs/hfsplus/brec.c b/fs/hfsplus/brec.c
> > > > index 808f4d8c859c..ed8eacb34452 100644
> > > > --- a/fs/hfsplus/brec.c
> > > > +++ b/fs/hfsplus/brec.c
> > > > @@ -73,9 +73,10 @@ int hfs_brec_insert(struct hfs_find_data *fd, void *entry, int entry_len)
> > > > if (!fd->bnode) {
> > > > if (!tree->root)
> > > > hfs_btree_inc_height(tree);
> > > > - fd->bnode = hfs_bnode_find(tree, tree->leaf_head);
> > > > - if (IS_ERR(fd->bnode))
> > > > - return PTR_ERR(fd->bnode);
> > >
> > >
> > > Are you sure that no caller is used this error code? Did you check this?
> > >
> > > Maybe, it makes sense to extract the error code and to show the error
> > > message on the caller side instead of processing the simple NULL?
> > >
> >
> > No response? Could we please get this wrapped up?
>
> I'm sorry, I thought you had picked this up already. Yes, I did check that
> no caller was using this. fd->bnode is always assumed to be NULL on error.
> Also, the error code is not lost, it's the return value of the function.
OK. Looks reasonable.
Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Thanks,
Vyacheslav Dubeyko.
prev parent reply other threads:[~2018-08-22 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 18:34 [PATCH 1/2] hfsplus: prevent crash on exit from failed search Ernesto A. Fernández
2018-06-29 18:37 ` [PATCH 2/2] hfs: " Ernesto A. Fernández
2018-07-02 18:01 ` [PATCH 1/2] hfsplus: " Viacheslav Dubeyko
2018-08-21 23:02 ` Andrew Morton
2018-08-22 18:11 ` Ernesto A. Fernández
2018-08-22 20:27 ` Viacheslav Dubeyko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534969667.2878.8.camel@slavad-ubuntu-14.04 \
--to=slava@dubeyko.com \
--cc=akpm@linux-foundation.org \
--cc=anatoly.trosinenko@gmail.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).