From: Rafael David Tinoco <rafael.tinoco@linaro.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: adobriyan@gmail.com, akpm@linux-foundation.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH] proc: fix and merge proc-self-map-file tests
Date: Fri, 09 Nov 2018 09:45:36 -0200 [thread overview]
Message-ID: <1541763936.3280758.1571224480.76F1EF1C@webmail.messagingengine.com> (raw)
In-Reply-To: <20181109114123.GK13195@uranus.lan>
On Fri, Nov 9, 2018, at 9:41 AM, Cyrill Gorcunov wrote:
> On Fri, Nov 09, 2018 at 09:30:36AM -0200, Rafael David Tinoco wrote:
> > Merge proc-self-map-files tests into one since this test should focus in
> > testing readlink in /proc/self/map_files/* only, and not trying to test
> > mapping virtual address 0.
> >
> > Lowest virtual address for user space mapping in other architectures,
> > like arm, is *at least* *(PAGE_SIZE * 2) and NULL hint does not
> > guarantee that when MAP_FIXED flag, important to this test, is given.
> > This patch also fixes this issue in remaining test.
> >
> > Link: https://bugs.linaro.org/show_bug.cgi?id=3782
> > Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
>
> Wait, Rafael. But we will loose the test of mapping virtual address 0
> then. I though you would move testing of virtual address 0 into
> a separate testcase. I mean testing of first page was a positive
> side effect of the former Alexey's patch, so we definitely should
> keep it on x86 at least. Gimme some time I'll try to address it
> today evening or tomorrow. I think this way everybody will be
> happy: procfs get passed on arm32 and x86 will still have first
> page testing.
Ohh, my understanding was that this was going to be addressed in some other test, like what you said.. I did not understand you wanted me to create a test for it altogether, my bad. I can do it if you want, let me know, pls.
Thanks!
next prev parent reply other threads:[~2018-11-09 21:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 18:43 [PATCH] proc: fix proc-self-map-files selftest for arm Rafael David Tinoco
2018-10-11 19:42 ` Cyrill Gorcunov
2018-10-11 20:56 ` Alexey Dobriyan
2018-10-11 21:02 ` Cyrill Gorcunov
2018-10-11 21:30 ` Alexey Dobriyan
2018-10-11 22:00 ` Cyrill Gorcunov
2018-10-15 16:55 ` Rafael David Tinoco
2018-10-15 17:21 ` Cyrill Gorcunov
2018-11-08 10:41 ` Rafael David Tinoco
2018-11-08 11:11 ` Cyrill Gorcunov
2018-11-09 11:30 ` [PATCH] proc: fix and merge proc-self-map-file tests Rafael David Tinoco
2018-11-09 11:41 ` Cyrill Gorcunov
2018-11-09 11:45 ` Rafael David Tinoco [this message]
2018-11-09 11:48 ` Cyrill Gorcunov
2018-11-09 12:01 ` Rafael David Tinoco
2018-11-09 18:04 ` Cyrill Gorcunov
2018-11-09 18:48 ` Rafael David Tinoco
2018-11-09 19:39 ` Cyrill Gorcunov
2018-11-10 17:47 ` Alexey Dobriyan
2018-11-10 17:56 ` Rafael David Tinoco
2018-11-10 18:49 ` Alexey Dobriyan
2018-11-11 2:50 ` Rafael David Tinoco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541763936.3280758.1571224480.76F1EF1C@webmail.messagingengine.com \
--to=rafael.tinoco@linaro.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).