From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1.zte.com.cn ([202.103.147.172]:53278 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbeK3Rkx (ORCPT ); Fri, 30 Nov 2018 12:40:53 -0500 From: Cheng Lin To: mcgrof@kernel.org Cc: keescook@chromium.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, zhong.weidong@zte.com.cn, wang.yi59@zte.com.cn, Cheng Lin Subject: [PATCH] proc/sysctl: fix return error for proc_doulongvec_minmax Date: Fri, 30 Nov 2018 14:35:17 +0800 Message-Id: <1543559717-27534-1-git-send-email-cheng.lin130@zte.com.cn> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: If the number of input parameters is less than the total parameters, an INVAL error will be returned. This patch ensure no error returned in this condition, just like other interfaces do. Signed-off-by: Cheng Lin --- kernel/sysctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 5fc724e..9ee261f 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2779,6 +2779,8 @@ static int __do_proc_doulongvec_minmax(void *data, struct ctl_table *table, int bool neg; left -= proc_skip_spaces(&p); + if (!left) + break; err = proc_get_long(&p, &left, &val, &neg, proc_wspace_sep, -- 1.8.3.1