Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
@ 2019-01-30 18:52 Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 1/3] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb() Waiman Long
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Waiman Long @ 2019-01-30 18:52 UTC (permalink / raw)
  To: Alexander Viro, Jonathan Corbet, Andrew Morton
  Cc: linux-kernel, linux-fsdevel, linux-mm, linux-doc,
	Luis R. Rodriguez, Kees Cook, Linus Torvalds, Jan Kara,
	Paul E. McKenney, Ingo Molnar, Miklos Szeredi, Matthew Wilcox,
	Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko, Waiman Long

 v3->v4:
  - Drop patch 4 as it is just a minor optimization.
  - Add a cc:stable tag to patch 1.
  - Clean up some comments in patch 3.

 v2->v3:
  - With confirmation that the dummy array in dentry_stat structure
    was never a replacement of a previously used field, patch 3 is now
    reverted back to use one of dummy field as the negative dentry count
    instead of adding a new field.

 v1->v2:
  - Clarify what the new nr_dentry_negative per-cpu counter is tracking
    and open-code the increment and decrement as suggested by Dave Chinner.
  - Append the new nr_dentry_negative count as the 7th element of dentry-state
    instead of replacing one of the dummy entries.
  - Remove patch "fs/dcache: Make negative dentries easier to be
    reclaimed" for now as I need more time to think about what
    to do with it.
  - Add 2 more patches to address issues found while reviewing the
    dentry code.
  - Add another patch to change the conditional branch of
    nr_dentry_negative accounting to conditional move so as to reduce
    the performance impact of the accounting code.

This patchset addresses 2 issues found in the dentry code and adds a
new nr_dentry_negative per-cpu counter to track the total number of
negative dentries in all the LRU lists.

Patch 1 fixes a bug in the accounting of nr_dentry_unused in
shrink_dcache_sb().

Patch 2 removes the ____cacheline_aligned_in_smp tag from super_block
LRU lists.

Patch 3 adds the new nr_dentry_negative per-cpu counter.

Various filesystem related tests were run and no statistically
significant changes in performance outside of the possible noise range
was observed.

Waiman Long (3):
  fs/dcache: Fix incorrect nr_dentry_unused accounting in
    shrink_dcache_sb()
  fs: Don't need to put list_lru into its own cacheline
  fs/dcache: Track & report number of negative dentries

 Documentation/sysctl/fs.txt | 26 ++++++++++++++++----------
 fs/dcache.c                 | 38 +++++++++++++++++++++++++++++++++-----
 include/linux/dcache.h      |  7 ++++---
 include/linux/fs.h          |  9 +++++----
 4 files changed, 58 insertions(+), 22 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [RESEND PATCH v4 1/3] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()
  2019-01-30 18:52 [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries Waiman Long
@ 2019-01-30 18:52 ` Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 2/3] fs: Don't need to put list_lru into its own cacheline Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries Waiman Long
  2 siblings, 0 replies; 14+ messages in thread
From: Waiman Long @ 2019-01-30 18:52 UTC (permalink / raw)
  To: Alexander Viro, Jonathan Corbet, Andrew Morton
  Cc: linux-kernel, linux-fsdevel, linux-mm, linux-doc,
	Luis R. Rodriguez, Kees Cook, Linus Torvalds, Jan Kara,
	Paul E. McKenney, Ingo Molnar, Miklos Szeredi, Matthew Wilcox,
	Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko, Waiman Long, stable

The nr_dentry_unused per-cpu counter tracks dentries in both the
LRU lists and the shrink lists where the DCACHE_LRU_LIST bit is set.
The shrink_dcache_sb() function moves dentries from the LRU list to a
shrink list and subtracts the dentry count from nr_dentry_unused. This
is incorrect as the nr_dentry_unused count Will also be decremented in
shrink_dentry_list() via d_shrink_del(). To fix this double decrement,
the decrement in the shrink_dcache_sb() function is taken out.

Fixes: 4e717f5c1083 ("list_lru: remove special case function list_lru_dispose_all."
Cc: stable@vger.kernel.org

Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
---
 fs/dcache.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 2593153..44e5652 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1188,15 +1188,11 @@ static enum lru_status dentry_lru_isolate_shrink(struct list_head *item,
  */
 void shrink_dcache_sb(struct super_block *sb)
 {
-	long freed;
-
 	do {
 		LIST_HEAD(dispose);
 
-		freed = list_lru_walk(&sb->s_dentry_lru,
+		list_lru_walk(&sb->s_dentry_lru,
 			dentry_lru_isolate_shrink, &dispose, 1024);
-
-		this_cpu_sub(nr_dentry_unused, freed);
 		shrink_dentry_list(&dispose);
 	} while (list_lru_count(&sb->s_dentry_lru) > 0);
 }
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [RESEND PATCH v4 2/3] fs: Don't need to put list_lru into its own cacheline
  2019-01-30 18:52 [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 1/3] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb() Waiman Long
@ 2019-01-30 18:52 ` Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries Waiman Long
  2 siblings, 0 replies; 14+ messages in thread
From: Waiman Long @ 2019-01-30 18:52 UTC (permalink / raw)
  To: Alexander Viro, Jonathan Corbet, Andrew Morton
  Cc: linux-kernel, linux-fsdevel, linux-mm, linux-doc,
	Luis R. Rodriguez, Kees Cook, Linus Torvalds, Jan Kara,
	Paul E. McKenney, Ingo Molnar, Miklos Szeredi, Matthew Wilcox,
	Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko, Waiman Long

The list_lru structure is essentially just a pointer to a table of
per-node LRU lists. Even if CONFIG_MEMCG_KMEM is defined, the list
field is just used for LRU list registration and shrinker_id is set
at initialization. Those fields won't need to be touched that often.

So there is no point to make the list_lru structures to sit in their
own cachelines.

Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
---
 include/linux/fs.h | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 811c777..29d8e2c 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1479,11 +1479,12 @@ struct super_block {
 	struct user_namespace *s_user_ns;
 
 	/*
-	 * Keep the lru lists last in the structure so they always sit on their
-	 * own individual cachelines.
+	 * The list_lru structure is essentially just a pointer to a table
+	 * of per-node lru lists, each of which has its own spinlock.
+	 * There is no need to put them into separate cachelines.
 	 */
-	struct list_lru		s_dentry_lru ____cacheline_aligned_in_smp;
-	struct list_lru		s_inode_lru ____cacheline_aligned_in_smp;
+	struct list_lru		s_dentry_lru;
+	struct list_lru		s_inode_lru;
 	struct rcu_head		rcu;
 	struct work_struct	destroy_work;
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries
  2019-01-30 18:52 [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 1/3] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb() Waiman Long
  2019-01-30 18:52 ` [RESEND PATCH v4 2/3] fs: Don't need to put list_lru into its own cacheline Waiman Long
@ 2019-01-30 18:52 ` Waiman Long
  2019-02-04 22:23   ` Luis Chamberlain
  2 siblings, 1 reply; 14+ messages in thread
From: Waiman Long @ 2019-01-30 18:52 UTC (permalink / raw)
  To: Alexander Viro, Jonathan Corbet, Andrew Morton
  Cc: linux-kernel, linux-fsdevel, linux-mm, linux-doc,
	Luis R. Rodriguez, Kees Cook, Linus Torvalds, Jan Kara,
	Paul E. McKenney, Ingo Molnar, Miklos Szeredi, Matthew Wilcox,
	Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko, Waiman Long

The current dentry number tracking code doesn't distinguish between
positive & negative dentries. It just reports the total number of
dentries in the LRU lists.

As excessive number of negative dentries can have an impact on system
performance, it will be wise to track the number of positive and
negative dentries separately.

This patch adds tracking for the total number of negative dentries
in the system LRU lists and reports it in the 5th field in the
/proc/sys/fs/dentry-state file. The number, however, does not include
negative dentries that are in flight but not in the LRU yet as well
as those in the shrinker lists which are on the way out anyway.

The number of positive dentries in the LRU lists can be roughly found
by subtracting the number of negative dentries from the unused count.

Matthew Wilcox had confirmed that since the introduction of the
dentry_stat structure in 2.1.60, the dummy array was there, probably for
future extension. They were not replacements of pre-existing fields. So
no sane applications that read the value of /proc/sys/fs/dentry-state
will do dummy thing if the last 2 fields of the sysctl parameter are
not zero. IOW, it will be safe to use one of the dummy array entry for
negative dentry count.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 Documentation/sysctl/fs.txt | 26 ++++++++++++++++----------
 fs/dcache.c                 | 32 ++++++++++++++++++++++++++++++++
 include/linux/dcache.h      |  7 ++++---
 3 files changed, 52 insertions(+), 13 deletions(-)

diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
index 819caf8..58649bd 100644
--- a/Documentation/sysctl/fs.txt
+++ b/Documentation/sysctl/fs.txt
@@ -56,26 +56,32 @@ of any kernel data structures.
 
 dentry-state:
 
-From linux/fs/dentry.c:
+From linux/include/linux/dcache.h:
 --------------------------------------------------------------
-struct {
+struct dentry_stat_t dentry_stat {
         int nr_dentry;
         int nr_unused;
         int age_limit;         /* age in seconds */
         int want_pages;        /* pages requested by system */
-        int dummy[2];
-} dentry_stat = {0, 0, 45, 0,};
--------------------------------------------------------------- 
-
-Dentries are dynamically allocated and deallocated, and
-nr_dentry seems to be 0 all the time. Hence it's safe to
-assume that only nr_unused, age_limit and want_pages are
-used. Nr_unused seems to be exactly what its name says.
+        int nr_negative;       /* # of unused negative dentries */
+        int dummy;             /* Reserved for future use */
+};
+--------------------------------------------------------------
+
+Dentries are dynamically allocated and deallocated.
+
+nr_dentry shows the total number of dentries allocated (active
++ unused). nr_unused shows the number of dentries that are not
+actively used, but are saved in the LRU list for future reuse.
+
 Age_limit is the age in seconds after which dcache entries
 can be reclaimed when memory is short and want_pages is
 nonzero when shrink_dcache_pages() has been called and the
 dcache isn't pruned yet.
 
+nr_negative shows the number of unused dentries that are also
+negative dentries which do not mapped to actual files.
+
 ==============================================================
 
 dquot-max & dquot-nr:
diff --git a/fs/dcache.c b/fs/dcache.c
index 44e5652..aac41ad 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -119,6 +119,7 @@ struct dentry_stat_t dentry_stat = {
 
 static DEFINE_PER_CPU(long, nr_dentry);
 static DEFINE_PER_CPU(long, nr_dentry_unused);
+static DEFINE_PER_CPU(long, nr_dentry_negative);
 
 #if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS)
 
@@ -152,11 +153,22 @@ static long get_nr_dentry_unused(void)
 	return sum < 0 ? 0 : sum;
 }
 
+static long get_nr_dentry_negative(void)
+{
+	int i;
+	long sum = 0;
+
+	for_each_possible_cpu(i)
+		sum += per_cpu(nr_dentry_negative, i);
+	return sum < 0 ? 0 : sum;
+}
+
 int proc_nr_dentry(struct ctl_table *table, int write, void __user *buffer,
 		   size_t *lenp, loff_t *ppos)
 {
 	dentry_stat.nr_dentry = get_nr_dentry();
 	dentry_stat.nr_unused = get_nr_dentry_unused();
+	dentry_stat.nr_negative = get_nr_dentry_negative();
 	return proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
 }
 #endif
@@ -317,6 +329,8 @@ static inline void __d_clear_type_and_inode(struct dentry *dentry)
 	flags &= ~(DCACHE_ENTRY_TYPE | DCACHE_FALLTHRU);
 	WRITE_ONCE(dentry->d_flags, flags);
 	dentry->d_inode = NULL;
+	if (dentry->d_flags & DCACHE_LRU_LIST)
+		this_cpu_inc(nr_dentry_negative);
 }
 
 static void dentry_free(struct dentry *dentry)
@@ -371,6 +385,11 @@ static void dentry_unlink_inode(struct dentry * dentry)
  * The per-cpu "nr_dentry_unused" counters are updated with
  * the DCACHE_LRU_LIST bit.
  *
+ * The per-cpu "nr_dentry_negative" counters are only updated
+ * when deleted from or added to the per-superblock LRU list, not
+ * from/to the shrink list. That is to avoid an unneeded dec/inc
+ * pair when moving from LRU to shrink list in select_collect().
+ *
  * These helper functions make sure we always follow the
  * rules. d_lock must be held by the caller.
  */
@@ -380,6 +399,8 @@ static void d_lru_add(struct dentry *dentry)
 	D_FLAG_VERIFY(dentry, 0);
 	dentry->d_flags |= DCACHE_LRU_LIST;
 	this_cpu_inc(nr_dentry_unused);
+	if (d_is_negative(dentry))
+		this_cpu_inc(nr_dentry_negative);
 	WARN_ON_ONCE(!list_lru_add(&dentry->d_sb->s_dentry_lru, &dentry->d_lru));
 }
 
@@ -388,6 +409,8 @@ static void d_lru_del(struct dentry *dentry)
 	D_FLAG_VERIFY(dentry, DCACHE_LRU_LIST);
 	dentry->d_flags &= ~DCACHE_LRU_LIST;
 	this_cpu_dec(nr_dentry_unused);
+	if (d_is_negative(dentry))
+		this_cpu_dec(nr_dentry_negative);
 	WARN_ON_ONCE(!list_lru_del(&dentry->d_sb->s_dentry_lru, &dentry->d_lru));
 }
 
@@ -418,6 +441,8 @@ static void d_lru_isolate(struct list_lru_one *lru, struct dentry *dentry)
 	D_FLAG_VERIFY(dentry, DCACHE_LRU_LIST);
 	dentry->d_flags &= ~DCACHE_LRU_LIST;
 	this_cpu_dec(nr_dentry_unused);
+	if (d_is_negative(dentry))
+		this_cpu_dec(nr_dentry_negative);
 	list_lru_isolate(lru, &dentry->d_lru);
 }
 
@@ -426,6 +451,8 @@ static void d_lru_shrink_move(struct list_lru_one *lru, struct dentry *dentry,
 {
 	D_FLAG_VERIFY(dentry, DCACHE_LRU_LIST);
 	dentry->d_flags |= DCACHE_SHRINK_LIST;
+	if (d_is_negative(dentry))
+		this_cpu_dec(nr_dentry_negative);
 	list_lru_isolate_move(lru, &dentry->d_lru, list);
 }
 
@@ -1816,6 +1843,11 @@ static void __d_instantiate(struct dentry *dentry, struct inode *inode)
 	WARN_ON(d_in_lookup(dentry));
 
 	spin_lock(&dentry->d_lock);
+	/*
+	 * Decrement negative dentry count if it was in the LRU list.
+	 */
+	if (dentry->d_flags & DCACHE_LRU_LIST)
+		this_cpu_dec(nr_dentry_negative);
 	hlist_add_head(&dentry->d_u.d_alias, &inode->i_dentry);
 	raw_write_seqcount_begin(&dentry->d_seq);
 	__d_set_inode_and_type(dentry, inode, add_flags);
diff --git a/include/linux/dcache.h b/include/linux/dcache.h
index ef4b70f..60996e6 100644
--- a/include/linux/dcache.h
+++ b/include/linux/dcache.h
@@ -62,9 +62,10 @@ struct qstr {
 struct dentry_stat_t {
 	long nr_dentry;
 	long nr_unused;
-	long age_limit;          /* age in seconds */
-	long want_pages;         /* pages requested by system */
-	long dummy[2];
+	long age_limit;		/* age in seconds */
+	long want_pages;	/* pages requested by system */
+	long nr_negative;	/* # of unused negative dentries */
+	long dummy;		/* Reserved for future use */
 };
 extern struct dentry_stat_t dentry_stat;
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries
  2019-01-30 18:52 ` [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries Waiman Long
@ 2019-02-04 22:23   ` Luis Chamberlain
  2019-02-04 22:28     ` Waiman Long
  0 siblings, 1 reply; 14+ messages in thread
From: Luis Chamberlain @ 2019-02-04 22:23 UTC (permalink / raw)
  To: Waiman Long
  Cc: Alexander Viro, Jonathan Corbet, Andrew Morton, linux-kernel,
	linux-fsdevel, linux-mm, linux-doc, Kees Cook, Linus Torvalds,
	Jan Kara, Paul E. McKenney, Ingo Molnar, Miklos Szeredi,
	Matthew Wilcox, Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko

Small nit below.

On Wed, Jan 30, 2019 at 01:52:38PM -0500, Waiman Long wrote:
> diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
>  
> +nr_negative shows the number of unused dentries that are also
> +negative dentries which do not mapped to actual files.

                     which are not mapped to actual files

Is that what you meant?

  Luis

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries
  2019-02-04 22:23   ` Luis Chamberlain
@ 2019-02-04 22:28     ` Waiman Long
  2019-02-04 22:31       ` Luis Chamberlain
  0 siblings, 1 reply; 14+ messages in thread
From: Waiman Long @ 2019-02-04 22:28 UTC (permalink / raw)
  To: Luis Chamberlain
  Cc: Alexander Viro, Jonathan Corbet, Andrew Morton, linux-kernel,
	linux-fsdevel, linux-mm, linux-doc, Kees Cook, Linus Torvalds,
	Jan Kara, Paul E. McKenney, Ingo Molnar, Miklos Szeredi,
	Matthew Wilcox, Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko

On 02/04/2019 05:23 PM, Luis Chamberlain wrote:
> Small nit below.
>
> On Wed, Jan 30, 2019 at 01:52:38PM -0500, Waiman Long wrote:
>> diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
>>  
>> +nr_negative shows the number of unused dentries that are also
>> +negative dentries which do not mapped to actual files.
>                      which are not mapped to actual files
>
> Is that what you meant?
>
>   Luis

Sorry for the grammatical error. Maybe I should send a patch to fix that.

Thanks,
Longman


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries
  2019-02-04 22:28     ` Waiman Long
@ 2019-02-04 22:31       ` Luis Chamberlain
  0 siblings, 0 replies; 14+ messages in thread
From: Luis Chamberlain @ 2019-02-04 22:31 UTC (permalink / raw)
  To: Waiman Long
  Cc: Alexander Viro, Jonathan Corbet, Andrew Morton, linux-kernel,
	linux-fsdevel, linux-mm, linux-doc, Kees Cook, Linus Torvalds,
	Jan Kara, Paul E. McKenney, Ingo Molnar, Miklos Szeredi,
	Matthew Wilcox, Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko

On Mon, Feb 04, 2019 at 05:28:00PM -0500, Waiman Long wrote:
> On 02/04/2019 05:23 PM, Luis Chamberlain wrote:
> > Small nit below.
> >
> > On Wed, Jan 30, 2019 at 01:52:38PM -0500, Waiman Long wrote:
> >> diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
> >>  
> >> +nr_negative shows the number of unused dentries that are also
> >> +negative dentries which do not mapped to actual files.
> >                      which are not mapped to actual files
> >
> > Is that what you meant?
> >
> >   Luis
> 
> Sorry for the grammatical error. Maybe I should send a patch to fix that.

If its already merged sure. Otherwise I don't care.

  Luis

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
  2019-01-30 18:35       ` Linus Torvalds
@ 2019-01-30 18:37         ` Waiman Long
  0 siblings, 0 replies; 14+ messages in thread
From: Waiman Long @ 2019-01-30 18:37 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Al Viro, Andrew Morton, Jonathan Corbet,
	Linux List Kernel Mailing, linux-fsdevel, Linux-MM, linux-doc,
	mcgrof, Kees Cook, Jan Kara, Paul McKenney, Ingo Molnar,
	Miklos Szeredi, Matthew Wilcox, lwoodman, James Bottomley,
	wangkai86, Michal Hocko

On 01/30/2019 01:35 PM, Linus Torvalds wrote:
> On Wed, Jan 30, 2019 at 8:40 AM Waiman Long <longman@redhat.com> wrote:
>> Ping. Will this patch be picked up?
> Can you re-send the patch-set and I'll just apply it directly since it
> seems to be languishing otherwise.
>
>                 Linus

Sure.

Thanks for your help.

-Longman


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
  2019-01-30 16:40     ` Waiman Long
@ 2019-01-30 18:35       ` Linus Torvalds
  2019-01-30 18:37         ` Waiman Long
  0 siblings, 1 reply; 14+ messages in thread
From: Linus Torvalds @ 2019-01-30 18:35 UTC (permalink / raw)
  To: Waiman Long
  Cc: Al Viro, Andrew Morton, Jonathan Corbet,
	Linux List Kernel Mailing, linux-fsdevel, Linux-MM, linux-doc,
	mcgrof, Kees Cook, Jan Kara, Paul McKenney, Ingo Molnar,
	Miklos Szeredi, Matthew Wilcox, lwoodman, James Bottomley,
	wangkai86, Michal Hocko

On Wed, Jan 30, 2019 at 8:40 AM Waiman Long <longman@redhat.com> wrote:
>
> Ping. Will this patch be picked up?

Can you re-send the patch-set and I'll just apply it directly since it
seems to be languishing otherwise.

                Linus

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
  2019-01-15 21:27   ` Waiman Long
  2019-01-15 21:27     ` Waiman Long
@ 2019-01-30 16:40     ` Waiman Long
  2019-01-30 18:35       ` Linus Torvalds
  1 sibling, 1 reply; 14+ messages in thread
From: Waiman Long @ 2019-01-30 16:40 UTC (permalink / raw)
  To: Al Viro, Andrew Morton
  Cc: Linus Torvalds, Jonathan Corbet, Linux List Kernel Mailing,
	linux-fsdevel, linux-mm, linux-doc, mcgrof, Kees Cook, Jan Kara,
	Paul McKenney, Ingo Molnar, mszeredi, Matthew Wilcox, lwoodman,
	James Bottomley, wangkai86, Michal Hocko

On 01/15/2019 04:27 PM, Waiman Long wrote:
> On 12/16/2018 02:37 PM, Linus Torvalds wrote:
>> On Fri, Dec 14, 2018 at 1:53 PM Waiman Long <longman@redhat.com> wrote:
>>> This patchset addresses 2 issues found in the dentry code and adds a
>>> new nr_dentry_negative per-cpu counter to track the total number of
>>> negative dentries in all the LRU lists.
>> The series looks sane to me. I'm assuming I'll get it either though
>> -mm or from Al..
>>
>>             Linus
> Could anyone pick up this patchset?
>
> Thanks,
> Longman
>
Ping. Will this patch be picked up?

Thanks,
Longman


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
  2018-12-16 19:37 ` Linus Torvalds
@ 2019-01-15 21:27   ` Waiman Long
  2019-01-15 21:27     ` Waiman Long
  2019-01-30 16:40     ` Waiman Long
  0 siblings, 2 replies; 14+ messages in thread
From: Waiman Long @ 2019-01-15 21:27 UTC (permalink / raw)
  To: Al Viro, Andrew Morton
  Cc: Linus Torvalds, Jonathan Corbet, Linux List Kernel Mailing,
	linux-fsdevel, linux-mm, linux-doc, mcgrof, Kees Cook, Jan Kara,
	Paul McKenney, Ingo Molnar, mszeredi, Matthew Wilcox, lwoodman,
	James Bottomley, wangkai86, Michal Hocko

On 12/16/2018 02:37 PM, Linus Torvalds wrote:
> On Fri, Dec 14, 2018 at 1:53 PM Waiman Long <longman@redhat.com> wrote:
>> This patchset addresses 2 issues found in the dentry code and adds a
>> new nr_dentry_negative per-cpu counter to track the total number of
>> negative dentries in all the LRU lists.
> The series looks sane to me. I'm assuming I'll get it either though
> -mm or from Al..
>
>             Linus

Could anyone pick up this patchset?

Thanks,
Longman

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
  2019-01-15 21:27   ` Waiman Long
@ 2019-01-15 21:27     ` Waiman Long
  2019-01-30 16:40     ` Waiman Long
  1 sibling, 0 replies; 14+ messages in thread
From: Waiman Long @ 2019-01-15 21:27 UTC (permalink / raw)
  To: Al Viro, Andrew Morton
  Cc: Linus Torvalds, Jonathan Corbet, Linux List Kernel Mailing,
	linux-fsdevel, linux-mm, linux-doc, mcgrof, Kees Cook, Jan Kara,
	Paul McKenney, Ingo Molnar, mszeredi, Matthew Wilcox, lwoodman,
	James Bottomley, wangkai86, Michal Hocko

On 12/16/2018 02:37 PM, Linus Torvalds wrote:
> On Fri, Dec 14, 2018 at 1:53 PM Waiman Long <longman@redhat.com> wrote:
>> This patchset addresses 2 issues found in the dentry code and adds a
>> new nr_dentry_negative per-cpu counter to track the total number of
>> negative dentries in all the LRU lists.
> The series looks sane to me. I'm assuming I'll get it either though
> -mm or from Al..
>
>             Linus

Could anyone pick up this patchset?

Thanks,
Longman


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
  2018-12-14 21:53 [RESEND PATCH v4 0/3] fs/dcache: Track # " Waiman Long
@ 2018-12-16 19:37 ` Linus Torvalds
  2019-01-15 21:27   ` Waiman Long
  0 siblings, 1 reply; 14+ messages in thread
From: Linus Torvalds @ 2018-12-16 19:37 UTC (permalink / raw)
  To: Waiman Long
  Cc: Al Viro, Jonathan Corbet, Andrew Morton,
	Linux List Kernel Mailing, linux-fsdevel, linux-mm, linux-doc,
	mcgrof, Kees Cook, Jan Kara, Paul McKenney, Ingo Molnar,
	mszeredi, Matthew Wilcox, lwoodman, James Bottomley, wangkai86,
	Michal Hocko

On Fri, Dec 14, 2018 at 1:53 PM Waiman Long <longman@redhat.com> wrote:
>
> This patchset addresses 2 issues found in the dentry code and adds a
> new nr_dentry_negative per-cpu counter to track the total number of
> negative dentries in all the LRU lists.

The series looks sane to me. I'm assuming I'll get it either though
-mm or from Al..

            Linus

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries
@ 2018-12-14 21:53 " Waiman Long
  2018-12-16 19:37 ` Linus Torvalds
  0 siblings, 1 reply; 14+ messages in thread
From: Waiman Long @ 2018-12-14 21:53 UTC (permalink / raw)
  To: Alexander Viro, Jonathan Corbet, Andrew Morton
  Cc: linux-kernel, linux-fsdevel, linux-mm, linux-doc,
	Luis R. Rodriguez, Kees Cook, Linus Torvalds, Jan Kara,
	Paul E. McKenney, Ingo Molnar, Miklos Szeredi, Matthew Wilcox,
	Larry Woodman, James Bottomley, Wangkai (Kevin C),
	Michal Hocko, Waiman Long

 v3->v4:
  - Drop patch 4 as it is just a minor optimization.
  - Add a cc:stable tag to patch 1.
  - Clean up some comments in patch 3.

 v2->v3:
  - With confirmation that the dummy array in dentry_stat structure
    was never a replacement of a previously used field, patch 3 is now
    reverted back to use one of dummy field as the negative dentry count
    instead of adding a new field.

 v1->v2:
  - Clarify what the new nr_dentry_negative per-cpu counter is tracking
    and open-code the increment and decrement as suggested by Dave Chinner.
  - Append the new nr_dentry_negative count as the 7th element of dentry-state
    instead of replacing one of the dummy entries.
  - Remove patch "fs/dcache: Make negative dentries easier to be
    reclaimed" for now as I need more time to think about what
    to do with it.
  - Add 2 more patches to address issues found while reviewing the
    dentry code.
  - Add another patch to change the conditional branch of
    nr_dentry_negative accounting to conditional move so as to reduce
    the performance impact of the accounting code.

This patchset addresses 2 issues found in the dentry code and adds a
new nr_dentry_negative per-cpu counter to track the total number of
negative dentries in all the LRU lists.

Patch 1 fixes a bug in the accounting of nr_dentry_unused in
shrink_dcache_sb().

Patch 2 removes the ____cacheline_aligned_in_smp tag from super_block
LRU lists.

Patch 3 adds the new nr_dentry_negative per-cpu counter.

Various filesystem related tests were run and no statistically
significant changes in performance outside of the possible noise range
was observed.

Waiman Long (3):
  fs/dcache: Fix incorrect nr_dentry_unused accounting in
    shrink_dcache_sb()
  fs: Don't need to put list_lru into its own cacheline
  fs/dcache: Track & report number of negative dentries

 Documentation/sysctl/fs.txt | 26 ++++++++++++++++----------
 fs/dcache.c                 | 38 +++++++++++++++++++++++++++++++++-----
 include/linux/dcache.h      |  7 ++++---
 include/linux/fs.h          |  9 +++++----
 4 files changed, 58 insertions(+), 22 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 18:52 [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries Waiman Long
2019-01-30 18:52 ` [RESEND PATCH v4 1/3] fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb() Waiman Long
2019-01-30 18:52 ` [RESEND PATCH v4 2/3] fs: Don't need to put list_lru into its own cacheline Waiman Long
2019-01-30 18:52 ` [RESEND PATCH v4 3/3] fs/dcache: Track & report number of negative dentries Waiman Long
2019-02-04 22:23   ` Luis Chamberlain
2019-02-04 22:28     ` Waiman Long
2019-02-04 22:31       ` Luis Chamberlain
  -- strict thread matches above, loose matches on Subject: below --
2018-12-14 21:53 [RESEND PATCH v4 0/3] fs/dcache: Track # " Waiman Long
2018-12-16 19:37 ` Linus Torvalds
2019-01-15 21:27   ` Waiman Long
2019-01-15 21:27     ` Waiman Long
2019-01-30 16:40     ` Waiman Long
2019-01-30 18:35       ` Linus Torvalds
2019-01-30 18:37         ` Waiman Long

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox