From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE18C169C4 for ; Mon, 11 Feb 2019 13:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A678D2229E for ; Mon, 11 Feb 2019 13:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727927AbfBKNnY (ORCPT ); Mon, 11 Feb 2019 08:43:24 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:37578 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727106AbfBKNnY (ORCPT ); Mon, 11 Feb 2019 08:43:24 -0500 X-UUID: 7375f090cb2047b8b24e3485793bd360-20190211 X-UUID: 7375f090cb2047b8b24e3485793bd360-20190211 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 385486582; Mon, 11 Feb 2019 21:43:18 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Feb 2019 21:43:17 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Feb 2019 21:43:17 +0800 From: Stanley Chu To: , CC: , , , , , Stanley Chu Subject: [PATCH v1] fcntl: Remove logically dead code Date: Mon, 11 Feb 2019 21:43:13 +0800 Message-ID: <1549892593-10619-1-git-send-email-stanley.chu@mediatek.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org The commit d08477aa975e ("fcntl: Don't use ambiguous SIG_POLL si_codes") added BUG_ON for below case, (reason - POLL_IN) >= NSIGPOLL Thus some statements become logically dead code and can be removed. Signed-off-by: Stanley Chu --- fs/fcntl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/fcntl.c b/fs/fcntl.c index 083185174c6d..11ec59bf421c 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -762,10 +762,7 @@ static void send_sigio_to_task(struct task_struct *p, reasons, otherwise we could leak kernel stack into userspace. */ BUG_ON((reason < POLL_IN) || ((reason - POLL_IN) >= NSIGPOLL)); - if (reason - POLL_IN >= NSIGPOLL) - si.si_band = ~0L; - else - si.si_band = mangle_poll(band_table[reason - POLL_IN]); + si.si_band = mangle_poll(band_table[reason - POLL_IN]); si.si_fd = fd; if (!do_send_sig_info(signum, &si, p, type)) break; -- 2.18.0