* [PATCH] vfs: Fix refcounting of filenames in fs_parser
@ 2019-03-18 16:57 David Howells
0 siblings, 0 replies; only message in thread
From: David Howells @ 2019-03-18 16:57 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, dhowells
Fix an overput in which filename_lookup() unconditionally drops a ref to
the filename it was given, but this isn't taken account of in the caller,
fs_lookup_param().
Addresses-Coverity-ID: 1443811 ("Use after free")
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/fs_parser.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fs_parser.c b/fs/fs_parser.c
index 842e8f749db6..be86703ec371 100644
--- a/fs/fs_parser.c
+++ b/fs/fs_parser.c
@@ -268,6 +268,7 @@ int fs_lookup_param(struct fs_context *fc,
return invalf(fc, "%s: not usable as path", param->key);
}
+ f->refcnt++; /* filename_lookup() drops our ref. */
ret = filename_lookup(param->dirfd, f, flags, _path, NULL);
if (ret < 0) {
errorf(fc, "%s: Lookup failure for '%s'", param->key, f->name);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-03-18 16:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 16:57 [PATCH] vfs: Fix refcounting of filenames in fs_parser David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).