From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A0BC43381 for ; Wed, 27 Mar 2019 23:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87C7C20651 for ; Wed, 27 Mar 2019 23:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732334AbfC0XqP (ORCPT ); Wed, 27 Mar 2019 19:46:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53992 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728360AbfC0XqP (ORCPT ); Wed, 27 Mar 2019 19:46:15 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B946858E5B; Wed, 27 Mar 2019 23:46:14 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB3E45C582; Wed, 27 Mar 2019 23:46:11 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [RFC PATCH 45/68] vfs: Move the subtype parameter into fuse From: David Howells To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com Date: Wed, 27 Mar 2019 23:46:11 +0000 Message-ID: <155373037117.7602.7890855019397429811.stgit@warthog.procyon.org.uk> In-Reply-To: <155372999953.7602.13784796495137723805.stgit@warthog.procyon.org.uk> References: <155372999953.7602.13784796495137723805.stgit@warthog.procyon.org.uk> User-Agent: StGit/unknown-version MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 27 Mar 2019 23:46:14 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Move as much as possible of the mount subtype apparatus into the fuse driver. The bits that are left involve determining whether it's permitted to split the filesystem type string passed in to mount(2). Consequently, this means that we cannot get rid of the FS_HAS_SUBTYPE flag unless we define that a type string with a dot in in always indicates a subtype specification. Signed-off-by: David Howells --- fs/fs_context.c | 12 ------------ fs/fuse/inode.c | 21 +++++++++++++++++++-- fs/super.c | 5 ----- include/linux/fs_context.h | 1 - 4 files changed, 19 insertions(+), 20 deletions(-) diff --git a/fs/fs_context.c b/fs/fs_context.c index fc8fda4b9fe9..f9ad2554c2b8 100644 --- a/fs/fs_context.c +++ b/fs/fs_context.c @@ -432,7 +432,6 @@ void put_fs_context(struct fs_context *fc) put_net(fc->net_ns); put_user_ns(fc->user_ns); put_cred(fc->cred); - kfree(fc->subtype); put_filesystem(fc->fs_type); kfree(fc->source); kfree(fc); @@ -498,17 +497,6 @@ static int legacy_parse_param(struct fs_context *fc, struct fs_parameter *param) return 0; } - if ((fc->fs_type->fs_flags & FS_HAS_SUBTYPE) && - strcmp(param->key, "subtype") == 0) { - if (param->type != fs_value_is_string) - return invalf(fc, "VFS: Legacy: Non-string subtype"); - if (fc->subtype) - return invalf(fc, "VFS: Legacy: Multiple subtype"); - fc->subtype = param->string; - param->string = NULL; - return 0; - } - if (ctx->param_type == LEGACY_FS_MONOLITHIC_PARAMS) return invalf(fc, "VFS: Legacy: Can't mix monolithic and individual options"); diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index bfcde29e4a1e..a655c1ef1424 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -65,6 +65,7 @@ static struct file_system_type fuseblk_fs_type; #endif struct fuse_fs_context { + const char *subtype; bool is_bdev; int fd; unsigned rootmode; @@ -455,6 +456,7 @@ static int fuse_statfs(struct dentry *dentry, struct kstatfs *buf) enum { OPT_SOURCE, + OPT_SUBTYPE, OPT_FD, OPT_ROOTMODE, OPT_USER_ID, @@ -468,6 +470,7 @@ enum { static const struct fs_parameter_spec fuse_param_specs[] = { fsparam_string ("source", OPT_SOURCE), + fsparam_string ("subtype", OPT_SUBTYPE), fsparam_fd ("fd", OPT_FD), fsparam_u32oct ("rootmode", OPT_ROOTMODE), fsparam_u32 ("user_id", OPT_USER_ID), @@ -496,11 +499,19 @@ static int fuse_parse_param(struct fs_context *fc, struct fs_parameter *param) switch (opt) { case OPT_SOURCE: - kfree(fc->source); + if (fc->source) + return invalf(fc, "fuse: Multiple sources specified"); fc->source = param->string; param->string = NULL; break; + case OPT_SUBTYPE: + if (ctx->subtype) + return invalf(fc, "fuse: Multiple subtypes specified"); + ctx->subtype = param->string; + param->string = NULL; + return 0; + case OPT_FD: ctx->fd = result.uint_32; ctx->fd_present = 1; @@ -556,7 +567,10 @@ static void fuse_free_fc(struct fs_context *fc) { struct fuse_fs_context *ctx = fc->fs_private; - kfree(ctx); + if (ctx) { + kfree(ctx->subtype); + kfree(ctx); + } } static int fuse_show_options(struct seq_file *m, struct dentry *root) @@ -1099,6 +1113,9 @@ static int fuse_fill_super(struct super_block *sb, struct fs_context *fsc) sb->s_blocksize = PAGE_SIZE; sb->s_blocksize_bits = PAGE_SHIFT; } + + sb->s_subtype = ctx->subtype; + ctx->subtype = NULL; sb->s_magic = FUSE_SUPER_MAGIC; sb->s_op = &fuse_super_operations; sb->s_xattr = fuse_xattr_handlers; diff --git a/fs/super.c b/fs/super.c index e9e678d2c37c..6cb57ad31e6f 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1539,11 +1539,6 @@ int vfs_get_tree(struct fs_context *fc) sb = fc->root->d_sb; WARN_ON(!sb->s_bdi); - if (fc->subtype && !sb->s_subtype) { - sb->s_subtype = fc->subtype; - fc->subtype = NULL; - } - /* * Write barrier is for super_cache_count(). We place it before setting * SB_BORN as the data dependency between the two functions is the diff --git a/include/linux/fs_context.h b/include/linux/fs_context.h index 9af788a3ef8e..70fdebf1dc85 100644 --- a/include/linux/fs_context.h +++ b/include/linux/fs_context.h @@ -84,7 +84,6 @@ struct fs_context { struct net *net_ns; /* The network namespace for this mount */ const struct cred *cred; /* The mounter's credentials */ const char *source; /* The source name (eg. dev path) */ - const char *subtype; /* The subtype to set on the superblock */ void *security; /* Linux S&M options */ void *s_fs_info; /* Proposed s_fs_info */ fmode_t bdev_mode; /* File open mode for bdev */