From: Bart Van Assche <bvanassche@acm.org>
To: Johannes Thumshirn <jthumshirn@suse.de>, Jens Axboe <axboe@fb.com>
Cc: Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux FSDEVEL Mailinglist <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX
Date: Wed, 03 Apr 2019 08:34:26 -0700 [thread overview]
Message-ID: <1554305666.118779.188.camel@acm.org> (raw)
In-Reply-To: <20190403091519.13376-1-jthumshirn@suse.de>
On Wed, 2019-04-03 at 11:15 +0200, Johannes Thumshirn wrote:
> With the introduction of BIO_NO_PAGE_REF we've used up all available bits
> in bio::bi_flags.
>
> Convert the defines of the flags to an enum and add a BUILD_BUG_ON() call
> to make sure no-one adds a new one and thus overrides the BVEC_POOL_IDX
> causing crashes.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2019-04-03 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 9:15 [PATCH] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX Johannes Thumshirn
2019-04-03 9:57 ` Ming Lei
2019-04-03 12:03 ` Hannes Reinecke
2019-04-03 15:34 ` Bart Van Assche [this message]
2019-04-03 19:50 ` Christoph Hellwig
2019-04-04 15:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554305666.118779.188.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).