linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chakra Divi <chakragithub@gmail.com>
To: linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>
Cc: Chakra Divi <chakragithub@gmail.com>
Subject: [PATCH] fuse:send filep uid as part of fuse write req
Date: Wed, 11 Sep 2019 10:15:17 +0000	[thread overview]
Message-ID: <1568196917-25674-1-git-send-email-chakragithub@gmail.com> (raw)

In current code in fuse write request current_fsuid is sent,
however this creates an issue in sudo execution context.
Changes to consider uid and gid from file struture pointer
that is created as part of open file instead of current_fsuid,gid

Steps to reproduce the issue:
1) create user1 and user2
2) create a file1 with user1 on fusemount
3) change the file1 permissions to 600
4) execute the following command
user1@linux# sudo -u user2 whoami >> /fusemnt/file1
Here write fails with permission denied error

on nfs and ext4 - above use case is working, but on fuse
its failing

Signed-off-by: Chakra Divi <chakragithub@gmail.com>
---
 fs/fuse/file.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 5ae2828..e1d223c 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1134,6 +1134,7 @@ static ssize_t fuse_perform_write(struct kiocb *iocb,
 	struct inode *inode = mapping->host;
 	struct fuse_conn *fc = get_fuse_conn(inode);
 	struct fuse_inode *fi = get_fuse_inode(inode);
+	struct file *file = iocb->ki_filp;
 	int err = 0;
 	ssize_t res = 0;
 
@@ -1150,6 +1151,9 @@ static ssize_t fuse_perform_write(struct kiocb *iocb,
 		if (IS_ERR(req)) {
 			err = PTR_ERR(req);
 			break;
+		} else {
+			req->in.h.uid = file->f_cred->uid.val;
+			req->in.h.gid = file->f_cred->gid.val;
 		}
 
 		count = fuse_fill_write_pages(req, mapping, ii, pos);
-- 
2.7.4


             reply	other threads:[~2019-09-11 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 10:15 Chakra Divi [this message]
2019-09-11 11:35 ` [PATCH] fuse:send filep uid as part of fuse write req Miklos Szeredi
     [not found]   ` <CAH7=fot46GSdanJg9P2rRKrxWnpZq7+vW2CVhtZvGzKTzk__nA@mail.gmail.com>
2019-09-12  7:32     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1568196917-25674-1-git-send-email-chakragithub@gmail.com \
    --to=chakragithub@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).