From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, dhowells@redhat.com,
Al Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org,
Seth Forshee <seth.forshee@canonical.com>
Subject: Re: [PATCH 1/1] fs: rethread notify_change to take a path instead of a dentry
Date: Sun, 01 Dec 2019 07:55:00 -0800 [thread overview]
Message-ID: <1575215700.3374.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <20191201114706.GL20752@bombadil.infradead.org>
On Sun, 2019-12-01 at 03:47 -0800, Matthew Wilcox wrote:
> On Sat, Nov 30, 2019 at 01:21:08PM -0800, James Bottomley wrote:
> > @@ -402,6 +403,10 @@ nfsd_setattr(struct svc_rqst *rqstp, struct
> > svc_fh *fhp, struct iattr *iap,
> >
> > dentry = fhp->fh_dentry;
> > inode = d_inode(dentry);
> > + path = &(struct path){
> > + .mnt = fhp->fh_export->ex_path.mnt,
> > + .dentry = dentry,
> > + };
>
> Is this really clearer than writing:
>
> path.mnt = fhp->fh_export->ex_path.mnt;
> path.dentry = dentry;
I'm not sure about clearer but certainly better: the general principle
is always do named structure initialization, so in my version any
unspecified fields are cleared. In your version they're set to
whatever uninitialized data was on the stack. For struct path, it
probably doesn't matter because it's only ever going to have two
elements for all time, but in general it does.
James
next prev parent reply other threads:[~2019-12-01 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 21:19 [PATCH 0/1] preparatory patch for a uid/gid shifting bind mount James Bottomley
2019-11-30 21:21 ` [PATCH 1/1] fs: rethread notify_change to take a path instead of a dentry James Bottomley
2019-12-01 7:04 ` Amir Goldstein
2019-12-01 16:00 ` James Bottomley
2019-12-03 0:54 ` [PATCH v2] " James Bottomley
2019-12-01 11:47 ` [PATCH 1/1] " Matthew Wilcox
2019-12-01 15:55 ` James Bottomley [this message]
2019-12-14 11:56 ` [PATCH 0/1] preparatory patch for a uid/gid shifting bind mount Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575215700.3374.4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=seth.forshee@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).