From: Eryu Guan <eguan@linux.alibaba.com>
To: linux-fsdevel@vger.kernel.org
Cc: virtio-fs@redhat.com, miklos@szeredi.hu,
Liu Bo <bo.liu@linux.alibaba.com>,
Eryu Guan <eguan@linux.alibaba.com>
Subject: [PATCH RFC] fuse: invalidate inode attr in writeback cache mode
Date: Wed, 6 May 2020 23:20:44 +0800 [thread overview]
Message-ID: <1588778444-28375-1-git-send-email-eguan@linux.alibaba.com> (raw)
Under writeback mode, inode->i_blocks is not updated, making utils like
du read st.blocks as 0.
For example, when using virtiofs (cache=always & nondax mode) with
writeback_cache enabled, writing a new file and check its disk usage
with du, du reports 0 usage.
# uname -r
5.6.0-rc6+
# mount -t virtiofs virtiofs /mnt/virtiofs
# rm -f /mnt/virtiofs/testfile
# create new file and do extend write
# xfs_io -fc "pwrite 0 4k" /mnt/virtiofs/testfile
wrote 4096/4096 bytes at offset 0
4 KiB, 1 ops; 0.0001 sec (28.103 MiB/sec and 7194.2446 ops/sec)
# stat -c %s,%b /mnt/virtiofs/testfile
4096,0 <==== i_size is correct, but block usage is 0
Fix it by invalidating attr in fuse_write_end(), like other write paths.
Signed-off-by: Eryu Guan <eguan@linux.alibaba.com>
---
fs/fuse/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 9d67b830fb7a..3c875104ca11 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2228,6 +2228,7 @@ static int fuse_write_end(struct file *file, struct address_space *mapping,
}
fuse_write_update_size(inode, pos + copied);
+ fuse_invalidate_attr(inode);
set_page_dirty(page);
unlock:
--
1.8.3.1
next reply other threads:[~2020-05-06 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 15:20 Eryu Guan [this message]
2020-05-11 13:06 ` [PATCH RFC] fuse: invalidate inode attr in writeback cache mode Miklos Szeredi
2020-05-12 2:06 ` Eryu Guan
2020-05-12 2:29 ` [PATCH v2] " Eryu Guan
2020-05-13 9:39 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588778444-28375-1-git-send-email-eguan@linux.alibaba.com \
--to=eguan@linux.alibaba.com \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).