From: "NeilBrown" <neilb@suse.de>
To: "bfields@fieldses.org" <bfields@fieldses.org>
Cc: "Trond Myklebust" <trondmy@hammerspace.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"dai.ngo@oracle.com" <dai.ngo@oracle.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: automatic freeing of space on ENOSPC
Date: Tue, 29 Jun 2021 11:43:45 +1000 [thread overview]
Message-ID: <162493102550.7211.15170485925982544813@noble.neil.brown.name> (raw)
In-Reply-To: <20210629011200.GA14733@fieldses.org>
On Tue, 29 Jun 2021, bfields@fieldses.org wrote:
> On Tue, Jun 29, 2021 at 12:43:14AM +0000, Trond Myklebust wrote:
> > How about just setting up a notification for unlink on those files, the
> > same way we set up notifications for close with the NFSv3 filecache in
> > nfsd?
>
> Yes, that'd probably work. It'd be better if we didn't have to throw
> away unlinked files when the client expires, but it'd still be an
> incremental improvement over what we do now.
I wonder how important this is. If an NFS client unlinks a file that it
has open, it will be silly_renamed, and if the client then goes silent,
it might never be removed. So we already theoretically have a
possibilty of ENOSPC due to silent clients. Have we heard of this
becoming a problem?
Is there reason to think that the Courteous server changes will make
this problem more likely?
NeilBrown
next prev parent reply other threads:[~2021-06-29 1:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 19:49 automatic freeing of space on ENOSPC J. Bruce Fields
2021-06-29 0:43 ` Trond Myklebust
2021-06-29 1:12 ` bfields
2021-06-29 1:43 ` NeilBrown [this message]
2021-06-29 4:07 ` Amir Goldstein
2021-06-29 18:34 ` bfields
2021-06-29 18:32 ` bfields
2021-06-29 18:39 ` Chuck Lever III
2021-06-29 5:11 ` Dave Chinner
2021-06-29 18:37 ` J. Bruce Fields
2021-06-29 16:47 ` Theodore Ts'o
2021-06-29 18:38 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162493102550.7211.15170485925982544813@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=bfields@fieldses.org \
--cc=dai.ngo@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).