From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42056 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727392AbeIUUqG (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 21 Sep 2018 16:46:06 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20180920151214.15484-5-mszeredi@redhat.com>
References: <20180920151214.15484-5-mszeredi@redhat.com> <20180920151214.15484-1-mszeredi@redhat.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: dhowells@redhat.com, Al Viro <viro@ZenIV.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] fsconfig: parse "subtype" param for old internal API
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16465.1537541810.1@warthog.procyon.org.uk>
Date: Fri, 21 Sep 2018 15:56:50 +0100
Message-ID: <16466.1537541810@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Miklos Szeredi <mszeredi@redhat.com> wrote:

> This subtype thing is specific to "fuse" and "fuseblk" filesystems.  When
> these are switched over to the new context API, the handling of this
> parameter can be moved from legacy_parse_param() into fuse.

I think do_new_mount() should do:

	vfs_parse_fs_string(fc, "subtype", subtype, strlen(subtype));

rather than setting fc->subtype itself.  I've made that change and folded this
patch also.

David