From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f196.google.com ([209.85.167.196]:42835 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725824AbeJLGdZ (ORCPT ); Fri, 12 Oct 2018 02:33:25 -0400 Received: by mail-oi1-f196.google.com with SMTP id w81-v6so8455561oiw.9 for ; Thu, 11 Oct 2018 16:03:58 -0700 (PDT) From: Paul Moore To: Jan Kara CC: , , , , Date: Thu, 11 Oct 2018 19:03:53 -0400 Message-ID: <166655f3fa8.2781.85c95baa4474aabc7814e68940a78392@paul-moore.com> In-Reply-To: <20181011113937.GD8418@quack2.suse.cz> References: <20180904160632.21210-1-jack@suse.cz> <20180904160632.21210-13-jack@suse.cz> <20181009074023.GD11150@quack2.suse.cz> <20181011113937.GD8418@quack2.suse.cz> Subject: Re: [PATCH 12/11 TESTSUITE] audit_testsuite: Add stress test for tree watches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On October 11, 2018 7:39:39 AM Jan Kara wrote: > On Wed 10-10-18 02:43:46, Paul Moore wrote: >> On Tue, Oct 9, 2018 at 3:40 AM Jan Kara wrote: >>> On Fri 05-10-18 17:06:22, Paul Moore wrote: >>>> On Tue, Sep 4, 2018 at 12:06 PM Jan Kara wrote: >>>>> Add stress test for stressing audit tree watches by adding and deleti= ng >>>>> rules while events are generated and watched filesystems are mounted = and >>>>> unmounted in parallel. >>>>> >>>>> Signed-off-by: Jan Kara >>>>> --- >>>>> tests/stress_tree/Makefile | 8 +++ >>>>> tests/stress_tree/test | 171 ++++++++++++++++++++++++++++++++++++= +++++++++ >>>>> 2 files changed, 179 insertions(+) >>>>> create mode 100644 tests/stress_tree/Makefile >>>>> create mode 100755 tests/stress_tree/test >>>> >>>> No commentary on the test itself, other than perhaps it should live >>>> under test_manual/, but in running the tests in a loop today I am >>>> reliably able to panic my test kernel after ~30m or so. >>> >>> Interesting. How do you run the test? >> >> Nothing fancy, just a simple bash loop: >> >> # cd tests/stress_tree >> # while ./test; do /bin/true; done > > OK, I did succeed in reproducing some problems with my patches - once I w= as > able to trigger a livelock and following softlockup warning - this is > actually a problem introduced by my patches, and once a use after free > issue (not sure what that was since after I've added some debugging I > wasn't able to trigger it anymore). Anyway, I'll try more after fixing th= e > livelock. Do you want me to add fixes on top of my series or just fixup t= he > original series? Since these are pretty serious bugs, and I try to avoid merging known-broke= n patches which will go up to Linus, why don't you go ahead and respin the = patchset with the new fixes included. You can also use the opportunity to = squash in the rename patch and fix that mid-patchset compilation problem th= at I fixed up during the merge. Thanks. -- paul moore www.paul-moore.com