From: David Howells <dhowells@redhat.com>
To: Andrei Vagin <avagin@openvz.org>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
Andrei Vagin <avagin@gmail.com>
Subject: Re: [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API
Date: Fri, 10 Aug 2018 23:55:30 +0100 [thread overview]
Message-ID: <16724.1533941730@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180810220027.2735-2-avagin@openvz.org>
Andrei Vagin <avagin@openvz.org> wrote:
> +static const char dev[] = "s test_fsopen_123";
Did you mean to prefix that with "s "?
> + if (sys_fsconfig(fsfd, FSCONFIG_SET_STRING, "source", dev, 0) < 0)
> + return pr_err("fsconfig_set_string sets source = %s", dev);
Note that it's not necessary to provide a source for /proc since it will just
ignore it.
Anyway, thanks for doing this!
David
next prev parent reply other threads:[~2018-08-11 1:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 22:00 [PATCH dhowells/mount-api 1/2] fs/fsconfig: handle FSCONFIG_CMD_RECONFIGURE Andrei Vagin
2018-08-10 22:00 ` [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API Andrei Vagin
2018-08-20 23:47 ` Dave Chinner
2018-08-10 22:52 ` [PATCH dhowells/mount-api 1/2] fs/fsconfig: handle FSCONFIG_CMD_RECONFIGURE David Howells
2018-08-10 22:55 ` David Howells [this message]
2018-08-20 23:29 ` [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API Andrei Vagin
2018-08-21 9:19 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16724.1533941730@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=avagin@gmail.com \
--cc=avagin@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).