From: Bob Peterson <rpeterso@redhat.com>
To: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ocfs2-devel@oss.oracle.com, cluster-devel@redhat.com,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Andreas Gruenbacher <agruenba@redhat.com>
Subject: Re: [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback
Date: Tue, 11 May 2021 08:19:38 -0400 (EDT) [thread overview]
Message-ID: <1750769001.24809997.1620735578939.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <4d120e2e-5eb4-1bbb-cc63-8c3b7c62dac0@oracle.com>
----- Original Message -----
> On 5/9/21 4:23 PM, Andrew Morton wrote:
>
> > On Mon, 26 Apr 2021 15:05:50 -0700 Junxiao Bi <junxiao.bi@oracle.com>
> > wrote:
> >
> >> When doing truncate/fallocate for some filesytem like ocfs2, it
> >> will zero some pages that are out of inode size and then later
> >> update the inode size, so it needs this api to writeback eof
> >> pages.
> > Seems reasonable. But can we please update the
> > __block_write_full_page_eof() comment? It now uses the wrong function
> > name and doesn't document the new `eof' argument.
>
> Jan suggested using sb_issue_zeroout to zero eof pages in
> ocfs2_fallocate, that can
>
> also fix the issue for ocfs2. For gfs2, i though it had the same issue,
> but i didn't get
>
> a confirm from gfs2 maintainer, if gfs2 is ok, then maybe this new api
> is not necessary?
>
> Thanks,
>
> Junxiao.
Hi,
Sorry. I was on holiday/vacation for the past week and a half without
Internet access except for my phone. I'll try to find the time to read
the thread and look into it soon.
Bob Peterson
prev parent reply other threads:[~2021-05-11 12:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 22:05 [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback Junxiao Bi
2021-04-26 22:05 ` [PATCH 2/3] ocfs2: allow writing back pages out of inode size Junxiao Bi
2021-04-28 16:00 ` Junxiao Bi
2021-04-29 13:09 ` [Ocfs2-devel] " Joseph Qi
2021-04-26 22:05 ` [PATCH 3/3] gfs2: fix out of inode size writeback Junxiao Bi
2021-04-28 16:02 ` Junxiao Bi
2021-04-29 11:58 ` [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback Joseph Qi
2021-04-29 17:14 ` [Cluster-devel] " Andreas Gruenbacher
2021-04-29 18:07 ` Junxiao Bi
2021-04-30 12:47 ` Jan Kara
2021-04-30 21:18 ` Junxiao Bi
2021-05-03 10:29 ` Jan Kara
2021-05-03 17:25 ` Junxiao Bi
2021-05-04 9:02 ` Jan Kara
2021-05-04 23:35 ` Junxiao Bi
2021-05-05 11:43 ` Jan Kara
2021-05-05 15:54 ` Junxiao Bi
2021-05-09 23:23 ` [Ocfs2-devel] " Andrew Morton
2021-05-10 22:15 ` Junxiao Bi
2021-05-11 12:19 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1750769001.24809997.1620735578939.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=jack@suse.cz \
--cc=junxiao.bi@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).