From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187E0C433B4 for ; Mon, 19 Apr 2021 20:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C333D61360 for ; Mon, 19 Apr 2021 20:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232530AbhDSUVU (ORCPT ); Mon, 19 Apr 2021 16:21:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42829 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbhDSUVU (ORCPT ); Mon, 19 Apr 2021 16:21:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618863649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nu5Hhf5tNHpLEdvJ7ADe17s8q+4aBttd2jGmtP4StII=; b=Om8A4gfWJQzDILQztyZUxTeDcXGgFsXyncpVEhftFvoPZjm4eNkxQvi5Bg17gTtzQJC8xG sFXYpws5Gxcfq4PG9YWY4MxL5cCQ2HtoWtGE6je7+zMQQnRCXGQWP3wIGZ2GShq3mOHNmD zmPAKICJSmlDoLUdaxCAX+thnO6ZnKY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-kKDIRTZ4M9KpT7jJO0mj2w-1; Mon, 19 Apr 2021 16:20:43 -0400 X-MC-Unique: kKDIRTZ4M9KpT7jJO0mj2w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AC5F64149; Mon, 19 Apr 2021 20:20:42 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-119-35.rdu2.redhat.com [10.10.119.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 634A65D72E; Mon, 19 Apr 2021 20:20:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210419201251.GE2531743@casper.infradead.org> References: <20210419201251.GE2531743@casper.infradead.org> To: Matthew Wilcox Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] smp_rmb_cond MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1929622.1618863640.1@warthog.procyon.org.uk> Date: Mon, 19 Apr 2021 21:20:40 +0100 Message-ID: <1929623.1618863640@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Matthew Wilcox wrote: > i see worse inlining decisions from gcc with this. maybe you see > an improvement that would justify it? > > [ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99998] Perhaps attach the patch to the bz, see if the compiler guys can recommend anything? David