From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: block: DMA alignment of IO buffer allocated from slab To: Christopher Lameter Cc: Christoph Hellwig , Vitaly Kuznetsov , Ming Lei , linux-block , linux-mm , Linux FS Devel , "open list:XFS FILESYSTEM" , Dave Chinner , Linux Kernel Mailing List , Ming Lei References: <20180920063129.GB12913@lst.de> <87h8ij0zot.fsf@vitty.brq.redhat.com> <20180921130504.GA22551@lst.de> <010001660c54fb65-b9d3a770-6678-40d0-8088-4db20af32280-000000@email.amazonses.com> <1f88f59a-2cac-e899-4c2e-402e919b1034@kernel.dk> <010001660cbd51ea-56e96208-564d-4f5d-a5fb-119a938762a9-000000@email.amazonses.com> From: Jens Axboe Message-ID: <1a5b255f-682e-783a-7f99-9d02e39c4af2@kernel.dk> Date: Mon, 24 Sep 2018 12:09:37 -0600 MIME-Version: 1.0 In-Reply-To: <010001660cbd51ea-56e96208-564d-4f5d-a5fb-119a938762a9-000000@email.amazonses.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On 9/24/18 12:00 PM, Christopher Lameter wrote: > On Mon, 24 Sep 2018, Jens Axboe wrote: > >> The situation is making me a little uncomfortable, though. If we export >> such a setting, we really should be honoring it... > > Various subsystems create custom slab arrays with their particular > alignment requirement for these allocations. Oh yeah, I think the solution is basic enough for XFS, for instance. They just have to error on the side of being cautious, by going full sector alignment for memory... -- Jens Axboe