From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6BFC388F9 for ; Tue, 3 Nov 2020 15:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C85FC2236F for ; Tue, 3 Nov 2020 15:58:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="p+QS+SZc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbgKCP6C (ORCPT ); Tue, 3 Nov 2020 10:58:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbgKCP6C (ORCPT ); Tue, 3 Nov 2020 10:58:02 -0500 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDEB4C0617A6 for ; Tue, 3 Nov 2020 07:58:01 -0800 (PST) Received: by mail-qv1-xf44.google.com with SMTP id d1so7345851qvl.6 for ; Tue, 03 Nov 2020 07:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2DFUWZMjdYCRr74/VE0fH9TXzYLb8WHFi/lJO7XkynM=; b=p+QS+SZcMezcXlGT7PQs4JqHZHD3ZQSkpsRcX+rRPAIDoTx/13pYLsy4664kWtr0Nh CWgjb39mZw+fBrlHyJZiIwsGeRJK5jmh8UR1FR43IsNfYoeEse8HBZ50upG9BeIKlcU3 Ix1V3kZwlUo1iKlDNpxjOmyPti+8wGF+qmY0hkLkO54+5sBKxAz66kCX6b/UCg0w4rKV YOrusaDHrNVHf85y3T7DECiJ0k+APxrgoh0Xf5VPsB6z517GK0t0BeN2o6f8frN54utd /OGxO000UtNVnSZnSYUxNKiWwxye4oXIHDUPgeFoZA/+7lJfrqv15zFr7gTDAQjHBWNK NbTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2DFUWZMjdYCRr74/VE0fH9TXzYLb8WHFi/lJO7XkynM=; b=fmy/jta1cv1namMqXIN7edVoPQhIrfEW86TPC/JJsqtOoUjuSq0FpqRiZh91piWiQA VWdp8a9pfi/KfqCF1OVZbIYjch/ghrr6mM0IKh0IgM/XlzITt95DMe38hPZHIZIgleJx ijJsbTFhB3mYnZBB6AdFKX4dsSNLc4dnjzd6dqMHjNfYCizzfO9vq+rrXCDKTCo0S5WM FWm7QlfoXoy64WfIL1yNuH9MeR9XePhHAie1Q6RwIS830ufFrEoedBBgcJbG06/1xKYs kOmwU2sj87S/yMR/106oI/85HkkShZzUp78N4UhJb2l5KeYzDE2TkGQy5fpDtV7xsq0r 9JXw== X-Gm-Message-State: AOAM5303eqWlp4EORKtFQBPfCyP7Q5Agulw25+u0fhRcl/cClu26x5qC mv0A+s8SpE4tS+eLUa9nqxfXyIs6DSeFAlrU X-Google-Smtp-Source: ABdhPJy1OqOJkyDQAwpboLIY8PUhJu0iOx+QcG9P521mi8o39xl0TuUmwFrSq4jOhbL0Uncp31FTCA== X-Received: by 2002:a0c:e1d1:: with SMTP id v17mr27799220qvl.15.1604419080903; Tue, 03 Nov 2020 07:58:00 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id d7sm10653153qkg.29.2020.11.03.07.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2020 07:58:00 -0800 (PST) Subject: Re: [PATCH v9 27/41] btrfs: introduce dedicated data write path for ZONED mode To: Naohiro Aota , linux-btrfs@vger.kernel.org, dsterba@suse.com Cc: hare@suse.com, linux-fsdevel@vger.kernel.org References: <72df5edeab150be3f081b0d96b174285f238eb0f.1604065695.git.naohiro.aota@wdc.com> From: Josef Bacik Message-ID: <1d3b3244-9b30-450e-66b7-0bef71842bd6@toxicpanda.com> Date: Tue, 3 Nov 2020 10:57:59 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <72df5edeab150be3f081b0d96b174285f238eb0f.1604065695.git.naohiro.aota@wdc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 10/30/20 9:51 AM, Naohiro Aota wrote: > If more than one IO is issued for one file extent, these IO can be written > to separate regions on a device. Since we cannot map one file extent to > such a separate area, we need to follow the "one IO == one ordered extent" > rule. > > The Normal buffered, uncompressed, not pre-allocated write path (used by > cow_file_range()) sometimes does not follow this rule. It can write a part > of an ordered extent when specified a region to write e.g., when its > called from fdatasync(). > > Introduces a dedicated (uncompressed buffered) data write path for ZONED > mode. This write path will CoW the region and write it at once. > > Signed-off-by: Naohiro Aota This can be modified to work in the way I described in the 'split ordered extent' patch, just flesh this out to do all the work together and that way you bypass all the ugly splitting stuff. Thanks, Josef