From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC45FC433DF for ; Fri, 5 Jun 2020 13:05:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B699206DC for ; Fri, 5 Jun 2020 13:05:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="bkqNLpnP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbgFENFF (ORCPT ); Fri, 5 Jun 2020 09:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbgFENFC (ORCPT ); Fri, 5 Jun 2020 09:05:02 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079D5C08C5C4 for ; Fri, 5 Jun 2020 06:05:00 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id nm22so2564987pjb.4 for ; Fri, 05 Jun 2020 06:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qMmRPUhgtpuS6TTG/GuqLkNjYHA8c+3dVy8v0SMwjMk=; b=bkqNLpnPAhUUJPYxLvISfFtr4FvME2B0TRGC5RqPoNt2xKQMu5TPyH7bQDFNomaW2y cdr68bxUbRNBYT56MpvLzMeWjqQKNeF6hCrfo/lQoE1/Op2UPzMm4h+6k3GRrK+xoyhJ jDJ79wGBXsMM6klm3WxyJ3PrEmmtbfPDKp/odfEuUPRyo2qdgY5Pwu2UggruUrqkZVLd V1/7DbEG/cyRRKhiiR4HVe0XetnFxxfYwe30V9ywHzffwSLPzwQY9QyB5LQxjExieX/Q d7ANk0zYFIrS0TD4DN9WEE5hJGkIeF348d8XPrtZsFZjaG7jaCjZPQJNKfsvsF0L/y78 4+Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qMmRPUhgtpuS6TTG/GuqLkNjYHA8c+3dVy8v0SMwjMk=; b=JEYn3iu/t00tkehFEdgyucf4POm7BMRKa7Ew1H7FN5xbAFhHiqj+1zM46TI8cWCxfj zgX9a3UXUwtG7jxMoMuUrElq5cYEAKGonTixatxsR9FFBkYr8D4PCTFg2uYJ6vFBLjy2 bxAPHXaBQxbAV05yqxcD03PNSaeYRMIMEJw2DcFzaBXNLRq/UbKcvNPfvilU4sHbdBQz 0VoIXwzEA37buOGs65fyuhrFOhDiv19zeYeNzoBBZLMXtt8uwwL/tIYR2jhcHl1PUDAf m33ZwKX167yQAa77nbKf7l72rCdCnO+HGntD+mz79p77zJjZt/Ho1GSCYX/CctumtfPO lsZg== X-Gm-Message-State: AOAM533US8j+R776e0/pnaCL9dOiWRn057zT1LvOwmKSH4lbT2LbeNEm +mkoyXvutWxPd8VSqXVDozBxRg== X-Google-Smtp-Source: ABdhPJztl3sgTYmes9QTZ50W/VL5LHmidIjsSGXV5BWpaw3tcv1f91aOZKJu3/pXlLzzR6iDp493gQ== X-Received: by 2002:a17:902:41:: with SMTP id 59mr9814427pla.104.1591362299795; Fri, 05 Jun 2020 06:04:59 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id 136sm7448369pfa.152.2020.06.05.06.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2020 06:04:58 -0700 (PDT) Subject: Re: block: Fix use-after-free in blkdev_get() To: Markus Elfring , Matthew Wilcox , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Dan Carpenter , Jason Yan , hulkci@huawei.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Christoph Hellwig , Jan Kara , Ming Lei References: <88676ff2-cb7e-70ec-4421-ecf8318990b1@web.de> <5fa658bf-3028-9b5c-30cc-dbdef6bf8f7a@huawei.com> <20200605094353.GS30374@kadam> <2ee6f2f7-eaec-e748-bead-0ad59f4c378b@web.de> <20200605111049.GA19604@bombadil.infradead.org> <20200605115158.GD19604@bombadil.infradead.org> <453060f2-80af-86a4-7e33-78d4cc87503f@web.de> From: Jens Axboe Message-ID: <1d95e2f6-7cf8-f0d3-bf8a-54d0a99c9ba1@kernel.dk> Date: Fri, 5 Jun 2020 07:04:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <453060f2-80af-86a4-7e33-78d4cc87503f@web.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 6/5/20 7:01 AM, Markus Elfring wrote: >>> The details can vary also for my suggestions. >>> Would you point any more disagreements out on concrete items? >> >> That's exactly the problem with many of your comments. >> They're vague to the point of unintelligibility. > > Was is so vague about possibilities which I point out for patch reviews > (for example)? > * Spelling corrections > * Additional wording alternatives I'll make this very simple - don't reply making suggestions to commit messages, ever. The "improvements" aren't usually improvements, and it causes more confusion for the submitter. Maintainers generally do change commit messages to improve them, if needed. No reply is needed to this e-mail. -- Jens Axboe