From: Christoph Hellwig <hch@infradead.org>
To: Masayoshi MIZUMA <m.mizuma@jp.fujitsu.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] update 068 to reproduce an unfreeze hanging up problem
Date: Wed, 4 Jan 2012 09:59:44 -0500 [thread overview]
Message-ID: <20120104145944.GA21381@infradead.org> (raw)
In-Reply-To: <20111214112209.1002.61FB500B@jp.fujitsu.com>
On Wed, Dec 14, 2011 at 11:22:10AM +0900, Masayoshi MIZUMA wrote:
> > test 068 will catch problems like the one your specific test
> > catches, but maybe not every time. Test 068 will catch problems your
> > test case won't, though - it's a trade-off between having lots of
> > tests that are similar but slightly different (difficult to
> > maintain, increases runtime, etc), and having one test that
> > exercises the functionality in a simple manner likely to detect
> > problems.
>
> Thank you for your explanation about the policy and I understand it.
> I tried to reproduce the problem not dropping the sleep, but the problem was
> not reproduced... Therefore, I dropped it and the problem was reproduced.
>
> However, as you mentioned, the problem is a timing proglem, so the
> my reproduction might be just by chance. Dropping sleep may increase
> the possibility of the reproduction, but not every time, so the change
> is not good. That is same for the arguments of fsstress which I changed.
>
> OK, I update 068 just to run other filesystem, ext3, ext4 and btrfs which
> I confirmed xfs_freeze works on.
> (xfs_freeze may work on the other filesystems which have freeze_fs/unfreeze_fs
> super_operations but I don't confirm...)
>
> The patch is below.
Given that MIZUMAs patch reproduces a real life issue I think adding
his original patch in addition to this change would be a good idea.
Dave, do you have a strong opinion against that?
next prev parent reply other threads:[~2012-01-04 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 0:42 [PATCH] update 068 to reproduce an unfreeze hanging up problem Masayoshi MIZUMA
2011-12-13 6:32 ` Dave Chinner
2011-12-14 2:22 ` Masayoshi MIZUMA
2012-01-04 14:59 ` Christoph Hellwig [this message]
2012-01-04 18:42 ` 068: run on more filesystems Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104145944.GA21381@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).