From: Christoph Hellwig <hch@infradead.org>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Abhijith Das <adas@redhat.com>, Jan Kara <jack@suse.cz>,
Steven Whitehouse <swhiteho@redhat.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV
Date: Tue, 20 Aug 2013 23:43:57 -0700 [thread overview]
Message-ID: <20130821064357.GA8822@infradead.org> (raw)
In-Reply-To: <1375828029-26360-2-git-send-email-sekharan@us.ibm.com>
Sorry for being late to the game, but I don not like the in-kernel
interface here at all. Given that Q_XGETQSTATV is a strict superset
of Q_XGETQSTAT there is no need for the second method - just always
fill out the larger in-kernel structure and only copy the smaller
information to userspace for the Q_XGETSTAT case. That keeps the amount
of code required in the implementations of the methods low and follows
the model used elsewhere in the kernel (e.g. stat and statfs)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-21 6:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 22:27 [PATCH 0/3] Add a new quotactl command to support 3 quota types in XFS Chandra Seetharaman
2013-08-06 22:27 ` [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV Chandra Seetharaman
2013-08-13 20:42 ` Rich Johnston
2013-08-13 20:50 ` Chandra Seetharaman
2013-08-13 21:22 ` Jan Kara
2013-08-13 22:22 ` Rich Johnston
2013-08-13 22:39 ` Chandra Seetharaman
2013-08-14 9:31 ` Jan Kara
2013-08-21 6:43 ` Christoph Hellwig [this message]
2013-08-21 13:01 ` Jan Kara
2013-08-21 18:12 ` Ben Myers
2013-08-21 18:19 ` Christoph Hellwig
2013-08-21 21:15 ` Chandra Seetharaman
2013-08-29 17:00 ` Chandra Seetharaman
2013-08-29 17:48 ` Ben Myers
2013-08-06 22:27 ` [PATCH 2/3] xfs: Add support for the Q_XGETQSTATV Chandra Seetharaman
2013-08-13 20:42 ` Rich Johnston
2013-08-06 22:27 ` [PATCH 3/3] gfs2: " Chandra Seetharaman
2013-08-13 20:42 ` Rich Johnston
2013-08-20 22:25 ` [PATCH 0/3] Add a new quotactl command to support 3 quota types in XFS Ben Myers
2013-08-21 12:28 ` Steven Whitehouse
2013-08-21 17:44 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821064357.GA8822@infradead.org \
--to=hch@infradead.org \
--cc=adas@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sekharan@us.ibm.com \
--cc=swhiteho@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).