From mboxrd@z Thu Jan 1 00:00:00 1970 From: "George Spelvin" Subject: Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount Date: 30 Aug 2013 23:06:33 -0400 Message-ID: <20130831030633.28455.qmail@science.horizon.com> Cc: linux@horizon.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk, waiman.long@hp.com To: torvalds@linux-foundation.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Just noticing that you are adding several functions that return a boolean value as an int. And a "gotref" local variable. Is that just not wanting to bother with thse newfangled C99 innovations, or do you dislike the "bool" type for some reason? Even if it doesn't change the code in the slightest, I like to declare things with the bool type for documentation. I can see avoiding code churn, but this is all new code, so I thought I'd ask. (FWIW, stdbool.h was in gcc 3.2, which README says is the minimum supported version, although that's probably outdated information.)