From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] vfs.git
Date: Thu, 11 Dec 2014 18:06:24 +0000 [thread overview]
Message-ID: <20141211180624.GX22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAELBmZDLTOskhHaZEMOPA8n9VgAcr0cJvqYjx=YADpx_=mYQcw@mail.gmail.com>
On Thu, Dec 11, 2014 at 05:18:21PM +0100, Miklos Szeredi wrote:
> On Wed, Dec 10, 2014 at 8:13 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> > * killing a bunch of ->f_path.dentry users (and f_dentry macro).
> > Getting that completed will make life much simpler for unionmount/overlayfs,
> > since then we'll be able to limit the places sensitive to file _dentry_
> > to reasonably few. Which allows to have file_inode(file) pointing to
> > inode in a covered layer, with dentry pointing to (negative) dentry in
> > union one. Still not complete, but much closer now.
>
> If we want f_path to point to union path, then shouldn't we be hiding
> it from all but core VFS? Filesystems have no business looking at the
> mount anyway. And looking at the union dentry will be just an endless
> source of bugs.
>
> Also some API changes are in order, like passing dentry to ->iterate()
> for "readdirplus" like operations, since f_path.dentry won't be usable
> for that purpose. Alternatively replace f_inode with f_dentry and
> make file_inode() use that.
Check the remaining users of ->f_path.dentry. I agree that they ought to
be encapsulated into a sane set of helpers - raw access to ->f_path in
filesystems is asking for serious trouble. And we have very few such places
remaining.
FWIW, I would prefer to have the whole stack of underlying dentries reachable
in a uniform way...
PS: I'll send review of your multilayer stuff today.
next prev parent reply other threads:[~2014-12-11 18:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 19:13 [GIT PULL] vfs.git Al Viro
2014-12-11 16:18 ` Miklos Szeredi
2014-12-11 18:06 ` Al Viro [this message]
2014-12-11 18:34 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2016-11-17 5:55 [git pull] vfs.git Al Viro
2016-11-11 6:05 Al Viro
2016-11-11 17:25 ` Linus Torvalds
2016-11-11 18:06 ` Ilya Dryomov
2016-11-12 3:36 ` Yan, Zheng
2016-10-11 3:07 Al Viro
2016-05-16 3:32 Al Viro
2016-05-16 15:43 ` Linus Torvalds
2016-05-17 6:27 ` Al Viro
2016-05-17 18:27 ` Linus Torvalds
2016-05-17 20:11 ` Al Viro
2016-03-20 1:44 Al Viro
2016-03-20 1:55 ` Linus Torvalds
2016-03-20 1:59 ` Al Viro
2015-04-24 20:40 Al Viro
2014-11-05 13:57 Al Viro
2014-11-02 5:58 Al Viro
2014-10-26 3:04 Al Viro
2014-05-28 6:38 Al Viro
2014-04-12 12:40 Al Viro
2014-04-13 18:53 ` Geert Uytterhoeven
2013-11-11 16:30 Al Viro
2013-11-13 14:52 ` J. Bruce Fields
2013-06-15 3:34 Al Viro
2012-12-21 0:21 Al Viro
2012-06-01 16:56 Al Viro
2012-06-01 17:38 ` Linus Torvalds
2012-06-01 17:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211180624.GX22149@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).