From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 04/79] ext4: split inode_operations for encrypted
 symlinks off the rest
Date: Tue, 5 May 2015 16:10:53 +0100
Message-ID: <20150505151052.GT889@ZenIV.linux.org.uk>
References: <20150505052205.GS889@ZenIV.linux.org.uk>
 <1430803373-4948-4-git-send-email-viro@ZenIV.linux.org.uk>
 <CA+55aFyfcDUc0SyHX+5vi4Qmb+Q3+TxyVxwq_S4Mp_MWTU1pJA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Neil Brown <neilb@suse.de>, Christoph Hellwig <hch@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <CA+55aFyfcDUc0SyHX+5vi4Qmb+Q3+TxyVxwq_S4Mp_MWTU1pJA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, May 05, 2015 at 08:01:52AM -0700, Linus Torvalds wrote:
> Ugh. Could we aim to *not* add code like this.
> 
> Instead, just declare (but don't define) the
> ext4_encrypted_symlink_inode_operations thing, so that *if* somebody
> uses it they get a link error, and make sure that
> "ext4_encrypted_inode()" ends up always returning zero when encryption
> isn't enabled, so that the compiler will actually optimize the whole
> thing out (which apparently is already the case, judging by the
> build-bug-on.

Sure, no problem.  BUILD_BUG_ON was used only because it triggered an
error earlier, I simply forgot to rip it out afterwards.