From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 51/79] namei: remove restrictions on nesting depth Date: Wed, 6 May 2015 08:24:07 +0100 Message-ID: <20150506072406.GX889@ZenIV.linux.org.uk> References: <20150505052205.GS889@ZenIV.linux.org.uk> <1430803373-4948-51-git-send-email-viro@ZenIV.linux.org.uk> <20150506125528.0be6d30e@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: NeilBrown Return-path: Content-Disposition: inline In-Reply-To: <20150506125528.0be6d30e@notabene.brown> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, May 06, 2015 at 12:55:28PM +1000, NeilBrown wrote: > > - if (unlikely(current->total_link_count >= 40)) { > > + if (unlikely(current->total_link_count >= MAXSYMLINKS)) { > > There is still a literal '40' in follow_automount. > > current->total_link_count++; > if (current->total_link_count >= 40) > return -ELOOP; > > > should that become MAXSYMLINKS too? Yes, assuming we want to keep it at all...