From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v2 11/51] memcg: implement mem_cgroup_css_from_page() Date: Wed, 27 May 2015 13:48:17 -0400 Message-ID: <20150527174817.GP7099@htj.duckdns.org> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-12-git-send-email-tj@kernel.org> <20150527161344.GO7099@htj.duckdns.org> <20150527170955.GA25324@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jack-AlSwsSmVLrQ@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, clm-b10kYP2dOMg@public.gmane.org, fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org, gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org To: Johannes Weiner Return-path: Content-Disposition: inline In-Reply-To: <20150527170955.GA25324-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org Hello, On Wed, May 27, 2015 at 01:09:55PM -0400, Johannes Weiner wrote: > Regular page migration uses mem_cgroup_migrate() as well, but it's not > a problem as it ensures that the old page doesn't have any outstanding > references at that point. Ooh, I see. > It's only replace_page_cache_page() that calls mem_cgroup_migrate() on > a live page breaking mem_cgroup_css_from_page(). > > So the page looks fine, I'd just update the culprit function in the > changelog and kerneldoc. Alright, will update the comment and description. Thanks. -- tejun