From: James Hogan <james.hogan@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
<Paul.Burton@imgtec.com>
Subject: Re: [PATCH]: ELF/MIPS build fix
Date: Fri, 20 May 2016 15:49:50 +0100 [thread overview]
Message-ID: <20160520144950.GA1145@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20160520141705.GA1913@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 4047 bytes --]
On Fri, May 20, 2016 at 04:17:05PM +0200, Ralf Baechle wrote:
> CONFIG_MIPS32_N32=y but CONFIG_BINFMT_ELF disabled results in the following
> linker errors:
>
> arch/mips/built-in.o: In function `elf_core_dump':
> binfmt_elfn32.c:(.text+0x23dbc): undefined reference to `elf_core_extra_phdrs'
> binfmt_elfn32.c:(.text+0x246e4): undefined reference to `elf_core_extra_data_size'
> binfmt_elfn32.c:(.text+0x248d0): undefined reference to `elf_core_write_extra_phdrs'
> binfmt_elfn32.c:(.text+0x24ac4): undefined reference to `elf_core_write_extra_data'
>
> CONFIG_MIPS32_O32=y but CONFIG_BINFMT_ELF disabled results in the following
> linker errors:
>
> arch/mips/built-in.o: In function `elf_core_dump':
> binfmt_elfo32.c:(.text+0x28a04): undefined reference to `elf_core_extra_phdrs'
> binfmt_elfo32.c:(.text+0x29330): undefined reference to `elf_core_extra_data_size'
> binfmt_elfo32.c:(.text+0x2951c): undefined reference to `elf_core_write_extra_phdrs'
> binfmt_elfo32.c:(.text+0x29710): undefined reference to `elf_core_write_extra_data'
>
> This is because binfmt_elfn32 and binfmt_elfo32 are using symbols
> from elfcore but for these configurations elfcore will not be built.
>
> Fixed by making elfcore selectable by a separate config symbol which
> unlike the current mechanism can also be used from other directories
> than kernel/, then having each flavor of ELF that relies on elfcore.o,
> select it in Kconfig, including CONFIG_MIPS32_N32 and CONFIG_MIPS32_O32
> which fixes this issue.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
FWIW this looks good to me,
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
> arch/mips/Kconfig | 1 +
> fs/Kconfig.binfmt | 8 ++++++++
> kernel/Makefile | 4 +---
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 5663f41..f19e15c 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -3116,6 +3116,7 @@ config MIPS32_N32
> config BINFMT_ELF32
> bool
> default y if MIPS32_O32 || MIPS32_N32
> + select ELFCORE
>
> endmenu
>
> diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt
> index 2d0cbbd..72c0335 100644
> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -1,6 +1,7 @@
> config BINFMT_ELF
> bool "Kernel support for ELF binaries"
> depends on MMU && (BROKEN || !FRV)
> + select ELFCORE
> default y
> ---help---
> ELF (Executable and Linkable Format) is a format for libraries and
> @@ -26,6 +27,7 @@ config BINFMT_ELF
> config COMPAT_BINFMT_ELF
> bool
> depends on COMPAT && BINFMT_ELF
> + select ELFCORE
>
> config ARCH_BINFMT_ELF_STATE
> bool
> @@ -34,6 +36,7 @@ config BINFMT_ELF_FDPIC
> bool "Kernel support for FDPIC ELF binaries"
> default y
> depends on (FRV || BLACKFIN || (SUPERH32 && !MMU) || C6X)
> + select ELFCORE
> help
> ELF FDPIC binaries are based on ELF, but allow the individual load
> segments of a binary to be located in memory independently of each
> @@ -43,6 +46,11 @@ config BINFMT_ELF_FDPIC
>
> It is also possible to run FDPIC ELF binaries on MMU linux also.
>
> +config ELFCORE
> + bool
> + help
> + This option enables kernel/elfcore.o.
> +
> config CORE_DUMP_DEFAULT_ELF_HEADERS
> bool "Write ELF core dumps with partial segments"
> default y
> diff --git a/kernel/Makefile b/kernel/Makefile
> index f0c40bf..e2ec54e 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -91,9 +91,7 @@ obj-$(CONFIG_TASK_DELAY_ACCT) += delayacct.o
> obj-$(CONFIG_TASKSTATS) += taskstats.o tsacct.o
> obj-$(CONFIG_TRACEPOINTS) += tracepoint.o
> obj-$(CONFIG_LATENCYTOP) += latencytop.o
> -obj-$(CONFIG_BINFMT_ELF) += elfcore.o
> -obj-$(CONFIG_COMPAT_BINFMT_ELF) += elfcore.o
> -obj-$(CONFIG_BINFMT_ELF_FDPIC) += elfcore.o
> +obj-$(CONFIG_ELFCORE) += elfcore.o
> obj-$(CONFIG_FUNCTION_TRACER) += trace/
> obj-$(CONFIG_TRACING) += trace/
> obj-$(CONFIG_TRACE_CLOCK) += trace/
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-20 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 14:17 [PATCH]: ELF/MIPS build fix Ralf Baechle
2016-05-20 14:49 ` James Hogan [this message]
2016-05-20 16:37 ` Maciej W. Rozycki
2016-05-20 16:40 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520144950.GA1145@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=Paul.Burton@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).