From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems
Date: Mon, 18 Jul 2016 12:47:07 +0100 [thread overview]
Message-ID: <20160718124707.6adfa9a1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1468812716-30537-11-git-send-email-nicolas.pitre@linaro.org>
On Sun, 17 Jul 2016 23:31:56 -0400
Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> Let's take the simple and obvious approach by decompressing the binary
> into a kernel buffer and then copying it to user space. Those who are
> looking for more performance on a MMU system are unlikely to choose this
> executable format anyway.
The flat loader takes a very casual attitude to overruns and corrupted
binaries. It's after all MMUless so has no real security model. If you
enable flat for an MMU system then IMHO those all need to be fixed
including all the missing overflow checks on the maths on textlen and the
like.
next prev parent reply other threads:[~2016-07-18 11:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 3:31 [PULL REQUEST] [PATCH v2 00/10] allow BFLT executables on systems with a MMU Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 01/10] binfmt_flat: assorted cleanups Nicolas Pitre
2016-07-19 4:52 ` Greg Ungerer
2016-07-19 6:40 ` Geert Uytterhoeven
2016-07-20 4:09 ` Nicolas Pitre
2016-07-20 6:54 ` Geert Uytterhoeven
2016-07-20 7:18 ` Greg Ungerer
2016-07-18 3:31 ` [PATCH v2 02/10] elf_fdpic_transfer_args_to_stack(): make it generic Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 03/10] binfmt_flat: use generic transfer_args_to_stack() Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 04/10] binfmt_flat: clean up create_flat_tables() and stack accesses Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 05/10] binfmt_flat: use proper user space accessors with relocs processing code Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 06/10] binfmt_flat: use proper user space accessors with old relocs code Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 07/10] binfmt_flat: use clear_user() rather than memset() to clear .bss Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 08/10] binfmt_flat: update libraries' data segment pointer with userspace accessors Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 09/10] binfmt_flat: add MMU-specific support Nicolas Pitre
2016-07-18 3:31 ` [PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre
2016-07-18 11:47 ` One Thousand Gnomes [this message]
2016-07-18 15:45 ` Nicolas Pitre
2016-07-18 16:51 ` One Thousand Gnomes
2016-07-18 16:58 ` Nicolas Pitre
2016-07-19 7:21 ` [PULL REQUEST] [PATCH v2 00/10] allow BFLT executables on systems with a MMU Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718124707.6adfa9a1@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dhowells@redhat.com \
--cc=gerg@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).