From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:46868 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbcGRQSx (ORCPT ); Mon, 18 Jul 2016 12:18:53 -0400 Date: Mon, 18 Jul 2016 09:18:25 -0700 From: "Darrick J. Wong" To: Brian Foster Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, Dave Chinner , xfs@oss.sgi.com Subject: Re: [PATCH 047/119] xfs: disable XFS_IOC_SWAPEXT when rmap btree is enabled Message-ID: <20160718161825.GB2494@birch.djwong.org> References: <146612627129.12839.3827886950949809165.stgit@birch.djwong.org> <146612657322.12839.9067889093004523073.stgit@birch.djwong.org> <20160718133428.GF27380@bfoster.bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160718133428.GF27380@bfoster.bfoster> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 18, 2016 at 09:34:28AM -0400, Brian Foster wrote: > On Thu, Jun 16, 2016 at 06:22:53PM -0700, Darrick J. Wong wrote: > > Swapping extents between two inodes requires the owner to be updated > > in the rmap tree for all the extents that are swapped. This code > > does not yet exist, so switch off the XFS_IOC_SWAPEXT ioctl until > > support has been implemented. This will need to be done before the > > rmap btree code can have the experimental tag removed. "This functionality will be provided in a (much) later patch, as the rmap implementation uses a few parts of the reflink functionality to accomplish its means." > > Signed-off-by: Dave Chinner > > [darrick.wong@oracle.com: fix extent swapping when rmap enabled] "[darrick: update commit log]" --D > > Signed-off-by: Darrick J. Wong > > --- > > Reviewed-by: Brian Foster > > > fs/xfs/xfs_bmap_util.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c > > index 450fd49..8666873 100644 > > --- a/fs/xfs/xfs_bmap_util.c > > +++ b/fs/xfs/xfs_bmap_util.c > > @@ -1618,6 +1618,10 @@ xfs_swap_extents( > > __uint64_t tmp; > > int lock_flags; > > > > + /* XXX: we can't do this with rmap, will fix later */ > > + if (xfs_sb_version_hasrmapbt(&mp->m_sb)) > > + return -EOPNOTSUPP; > > + > > tempifp = kmem_alloc(sizeof(xfs_ifork_t), KM_MAYFAIL); > > if (!tempifp) { > > error = -ENOMEM; > > > > _______________________________________________ > > xfs mailing list > > xfs@oss.sgi.com > > http://oss.sgi.com/mailman/listinfo/xfs