From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:52044 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbcGSDrg (ORCPT ); Mon, 18 Jul 2016 23:47:36 -0400 Date: Mon, 18 Jul 2016 20:47:36 -0700 From: Christoph Hellwig To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-api@vger.kernel.org Subject: Re: [PATCH 3/3] f2fs: support clone_file_range Message-ID: <20160719034736.GA4037@infradead.org> References: <20160717062427.56718-1-jaegeuk@kernel.org> <20160717062427.56718-3-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160717062427.56718-3-jaegeuk@kernel.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jul 16, 2016 at 11:24:27PM -0700, Jaegeuk Kim wrote: > This patch implements clone_file_range in f2fs. [...] > +int f2fs_clone_file_range(struct file *file_in, loff_t pos_in, > + struct file *file_out, loff_t pos_out, u64 len) > +{ > + return f2fs_clone_files(file_in, pos_in, file_out, pos_out, len); > +} > + Falling back from copy to clone should be done in the VFS. I look into implementing the fallback, and the code is trivial, but we don't seem to have any useful coverage for copy_file_range yet, so I didn't dare to add it yet. How did you test copy and clone in f2fs? And how did you handle the difference in corner cases (e.g. the lacking 0 special case in copy)?