From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:35974 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbcHAGeT (ORCPT ); Mon, 1 Aug 2016 02:34:19 -0400 Date: Sun, 31 Jul 2016 23:34:18 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, bfoster@redhat.com, xfs@oss.sgi.com Subject: Re: [PATCH 03/47] xfs: fix attr shortform structure alignment on cris Message-ID: <20160801063418.GE15590@infradead.org> References: <146907695530.25461.3225785294902719773.stgit@birch.djwong.org> <146907698036.25461.13007151908183013504.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146907698036.25461.13007151908183013504.stgit@birch.djwong.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 20, 2016 at 09:56:20PM -0700, Darrick J. Wong wrote: > Apparently cris doesn't require structure stride to align with the > largest type in the struct, so list[0] isn't at offset 4 like it is > everywhere else. Fix this... insofar as existing XFSes on cris are > screwed. > > Signed-off-by: Darrick J. Wong Looks fine and should go in ASAP: Reviewed-by: Christoph Hellwig