From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:34997 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbcHFUg2 (ORCPT ); Sat, 6 Aug 2016 16:36:28 -0400 Date: Sat, 6 Aug 2016 19:35:49 +0100 From: Salah Triki To: Luis de Bethencourt Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] fs: befs: remove in vain variable assignment Message-ID: <20160806183549.GB3423@pc> References: <579F4D92.6020701@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <579F4D92.6020701@osg.samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 01, 2016 at 02:24:34PM +0100, Luis de Bethencourt wrote: > On 31/07/16 21:34, Salah Triki wrote: > > There is no need to set *value, it will be overwritten later. > > > > Signed-off-by: Salah Triki > > --- > > fs/befs/btree.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > > index a0e8cfa..f33fc6c 100644 > > --- a/fs/befs/btree.c > > +++ b/fs/befs/btree.c > > @@ -348,8 +348,6 @@ befs_find_key(struct super_block *sb, struct befs_btree_node *node, > > > > befs_debug(sb, "---> %s %s", __func__, findkey); > > > > - *value = 0; > > - > > findkey_len = strlen(findkey); > > > > /* if node can not contain key, just skeep this node */ > > > > Hi Salah, > > The key here is that befs_btree_find(), the only consumer of befs_find_key(), > doesn't use the value if the return is BEFS_BT_NOT_FOUND. > > Tested the patch anyway to be sure. > > Acked-by: Luis de Bethencourt > > Pushed to the befs-next branch: > https://github.com/luisbg/linux-befs/tree/befs-next > > Thanks! > Luis Thanx :) Salah